add Ternary Search code[C++] #541
Conversation
|
Hi! Thanks for showing interest in contributing to this repository. Please make sure that you have ticked the points mentioned in PR description correctly. Thanks again! |
ternary_search/ternary_search.cpp
Outdated
| * Time Complexity : O(max(input)) | ||
| */ | ||
| int ternary_search (int ar[],int n, int left, int right, int x) | ||
| { |
There was a problem hiding this comment.
Please follow Google C++ Style Guide,
function(param) {
if(condition) {
}
}
ternary_search/ternary_search.cpp
Outdated
|
|
||
| int main() | ||
| { | ||
| int s = 12; |
ternary_search/ternary_search.cpp
Outdated
| } | ||
| else | ||
| { | ||
| cout<<"The index is:"<<ternary_search(v,s,left-1,right-1,x)<<"\n"; |
There was a problem hiding this comment.
Please put space around << and all binary operators.
ternary_search/ternary_search.cpp
Outdated
| { | ||
| int s = 12; | ||
| int v[s]; | ||
| short x; |
There was a problem hiding this comment.
Please use common english words instead of single letter variable names.
ternary_search/ternary_search.cpp
Outdated
| return right; | ||
| } | ||
|
|
||
| // Update the two index left and right if the element is not found. |
There was a problem hiding this comment.
Please put comments above the relevant blocks and remove unnecessary blank lines.
ternary_search/ternary_search.cpp
Outdated
| ar[i - 1] = i; | ||
| } | ||
| cout << "Enter number for research:\n"; | ||
| cin >> x; |
There was a problem hiding this comment.
Don't ask for any input, take any sample value.
ternary_search/ternary_search.cpp
Outdated
| int left = space / 3; | ||
| int right = (space / 3) * 2; | ||
|
|
||
| if(ternary_search(ar,space,left - 1,right - 1,x) == -1){ |
There was a problem hiding this comment.
Put a space after each ,(comma).
ternary_search/ternary_search.cpp
Outdated
| * x : element to be searched. | ||
| * Time Complexity : O(max(input)) | ||
| */ | ||
| int ternary_search (int ar[],int n, int left, int right, int x){ |
There was a problem hiding this comment.
Put a space after each ,, (comma).
ternary_search/ternary_search.cpp
Outdated
|
|
||
|
|
||
| if(x < ar[left]){ | ||
| return ternary_search(ar,n,left - 1,right,x); |
There was a problem hiding this comment.
Put a space after each ,, (comma).
ternary_search/ternary_search.cpp
Outdated
| } | ||
|
|
||
| if (x > ar[left] && x < ar[right]){ | ||
| return ternary_search(ar,n,left + 1,right - 1,x); |
There was a problem hiding this comment.
Put a space after each ,, (comma).
ternary_search/ternary_search.cpp
Outdated
| } | ||
|
|
||
| if(x > ar[right]){ | ||
| return ternary_search(ar,n,left,right + 1,x); |
There was a problem hiding this comment.
Put a space after each ,, (comma).
|
@RobinChao: Are you still on it? |
Fixes #481
By submitting this pull request I confirm I've read and complied with the below declarations.
Added {Algorithm/DS name} [{Language}], notUpdate README.mdorAdded new code.