Modified code Largest Sum Contiguous Subarray [C, Java] #421
Conversation
| @@ -14,12 +14,9 @@ public static int largestSumContiguousSubarray(int[] array) { // maximum sum | |||
| prevSum = array[0]; // initialize current sum amd previous sum | |||
| currentSum = array[0]; | |||
| for (i = 1; i < array.length; i++) { | |||
There was a problem hiding this comment.
i can be declared here only like for (int i = 1; i < array.length; i++) and remove line 13
aashutoshrathi
changed the title
| } | ||
|
|
||
| int main() { | ||
| int array[] = {-2, 1, -3, 4, -1, 2, 1, -5, 4, 5}; | ||
| printf("%d", largestSumContinousSubArray(array, 10)); |
There was a problem hiding this comment.
Either change Continous to Continuous (as previous one is type) or Contiguous (as filename suggests).
There was a problem hiding this comment.
Instead of 10 place size there; where size = sizeof(array)/sizeof(array[0]);
| } | ||
|
|
||
| int main() { | ||
| int array[] = {-2, 1, -3, 4, -1, 2, 1, -5, 4, 5}; | ||
| printf("%d", largestSumContinousSubArray(array, 10)); |
There was a problem hiding this comment.
Instead of 10 place size there; where size = sizeof(array)/sizeof(array[0]);
| } | ||
|
|
||
| int main() { | ||
| int array[] = {-2, 1, -3, 4, -1, 2, 1, -5, 4, 5}; | ||
| printf("%d", largestSumContinousSubArray(array, 10)); |
|
|
||
| int main() { | ||
| int array[] = {-2, 1, -3, 4, -1, 2, 1, -5, 4, 5}; | ||
| int size = sizeof(array)/sizeof(array[0]); |
There was a problem hiding this comment.
add whitespace around / and its done. 👍
| @@ -1,25 +1,27 @@ | |||
| #include <stdio.h> | |||
| #include <stdlib.h> | |||
|
|
|||
| int largestSumContinousSubArray(int arr[], int size) { | |||
| int largestSumContiguousSubArray(int arr[], int size) { | |||
There was a problem hiding this comment.
It should be largestSumContiguousSubarray. i.e. same as filename.
There was a problem hiding this comment.
@jsroyal We should rename the file to ...SubArray.c
| int array[10]; | ||
| for (int k = 0; k < 10; k++) { | ||
| array[k] = rand() % 10; | ||
| int max(int first, int second) { |
There was a problem hiding this comment.
#define max(a,b) (((a)>(b)) ? (a) : (b))
Better use this.
|
|
||
| int largestSumContinousSubArray(int arr[], int size) { | ||
| int largestSumContiguousSubarray(int arr[], int size) { |
There was a problem hiding this comment.
@jsroyal Sir please fix the function name as per C guidelines.
|
@jsroyal: Please reopen if you wish to continue. |
Fixes #420
By submitting this pull request I confirm I've read and complied with the below declarations.
Added {Algorithm/DS name} [{Language}], notUpdate README.mdorAdded new code.