Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Floyd Warshall [Java] #371

Closed
wants to merge 10 commits into from
Closed

Added Floyd Warshall [Java] #371

wants to merge 10 commits into from

Conversation

TarunISCO
Copy link
Member

Fixes #368

By submitting this pull request I confirm I've read and complied with the below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the coding guidelines for this project.
  • My code follows the skeleton code structure.
  • This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

@aashutoshrathi
Copy link
Member

@TarunISCO Sir, rebase and make sure you follow This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.

@TarunISCO TarunISCO changed the title Adding floyd warshall Added Floyd Warshall [Java] Jun 27, 2017
@yashLadha
Copy link
Member

Rebase the commits @TarunISCO

Copy link
Member

@yashLadha yashLadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please See comments

@@ -0,0 +1,60 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't Include files that are not relevant to this PR

@yashLadha
Copy link
Member

yashLadha commented Jul 1, 2017

@TarunISCO Please reset your branch and push changes that releveant to this PR.
For that you can use

git fetch <remote>/master
git reset --hard <remote>/master
git pull <remote>/master

remote is the remote name of the iiitv/algos repo

or an alternative is drop the commits that are not relevant and them pull changes from master branch and rebase on top of that, so that your commits come on top of the changes, and them force push them.

Make the changes relevant to PR, commit them and them push them again.
Make sure that when syncing branch with master, you don't push changes of others. A workthrough for that is rebase your commits from the head. If you need help, you can ask on gitter, but don't push changes that are not relevant. At least have a look at diff, you are commiting.

@aashutoshrathi
Copy link
Member

There is no activity from 27 days.

@Monal5031
Copy link
Member

Monal5031 commented Aug 22, 2017

@aviaryan @singhpratyush Sir no activity on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floyd Warshall [Java]
6 participants