Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #19: when input data has no non-co2 variables #22

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jkikstra
Copy link
Collaborator

For full description of error, see #19.

  • Tests added
  • Documentation added/changed if necessary
  • Example added (in the documentation, to an existing notebook, or in a new notebook)
  • Description in CHANGELOG.rst added (single line such as: (`#XX <https://github.com/iiasa/climate-assessment/pull/XX>`_) Added feature which does something)

@jkikstra jkikstra marked this pull request as draft December 12, 2022 23:31
@jkikstra
Copy link
Collaborator Author

Wrote an ad-hoc fix.

@phackstock if you need this soon, would you perhaps be able to take this a bit further (i.e. maybe a tests/docs, and check if my implementation makes sense)?

@znicholls FYI

@znicholls
Copy link
Collaborator

@znicholls FYI

Thanks, I put my comments in the issue to keep things in one place, implementation looks fine and I think adding tests/docs would be great (there's probably a much larger conversation to be had about whether we want to put more effort into cleaning things up in the repo in general, let me know if you have thoughts on that too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants