Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline version string of CLI between emulators (at least FaIR and MAGICC) #39

Open
jkikstra opened this issue Jun 21, 2023 · 2 comments

Comments

@jkikstra
Copy link
Collaborator

At the moment it looks like we need to do:

--model "magicc" --version "v7.5.3"

and

--model "fair" --version "1.6.2"

It's confusing to have "v" for magicc but not for fair.


P.S. note that CICERO has a different version naming entirely: "v2019vCH4"

Line for FAIR:

DEFAULT_FAIR_VERSION = "1.6.2"

Line for MAGICC:

DEFAULT_MAGICC_VERSION = "v7.5.3"

Line for CICERO:

DEFAULT_CICEROSCM_VERSION = "v2019vCH4"

(ping @phackstock)

@phackstock
Copy link
Contributor

Thanks @jkikstra, that'll prove really useful in the future.

@jkikstra
Copy link
Collaborator Author

Just an extra note: I think these "DEFAULT_*_VERSION" variables are actually not used in the output data (and so do also not feature in the test-data files), which would make life easier in changing this.
One suggestion would we to change all three to "ipcc_ar6" or "ipcc_ar6wg3" or simply "ar6".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants