Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding of bridge parts over land #146

Closed
Christian-Shom opened this issue Mar 26, 2024 · 4 comments
Closed

Encoding of bridge parts over land #146

Christian-Shom opened this issue Mar 26, 2024 · 4 comments

Comments

@Christian-Shom
Copy link
Collaborator

It is unclear to me on how should we encode parts of a bridge that are situated on land (when the part over navigable water is encoded with a Span (Fixed or Opening).
For more details, please refer to paper from Friedhelm in iho-ohi/S-57-to-S-101-conversion-sub-WG#6.
As DCEG 6.7.1 and 6.8.1 states: "Span Fixed features should only be encoded if the span is entirely or partly over navigable water at the optimum display scale for the ENC data."
which feature should we encode on the areas in blue in this figure?
image
If in S-57 ENC, the real world object is encoded with 3 separate BRIDGE features, I guess they will be converted into 3 Spans, which contradicts the wording in the DCEG.

@HermanSchouten
Copy link

We also encountered this. We are currently changing all bridges in our S-57 Database, and are clipping the BRIDGE features so that they don't overlap LNDARE anymore.
The areas marked in blue will be a ROADWY, so not representing reality. We have had some discussions on this.

@Richard-Fowle
Copy link

If areas in blue are still part of the Bridge then I think they should should be encoded as Bridge features.
My thinking in this case is that the two Pylon features and one Span Fixed feature together with the two Bridge features would then all be associated using the Bridge Aggregation. Although if that is the case then perhaps Figure 6.2 should be extended to cover the parts of the bridge that are not over navigable water

@JeffWootton
Copy link
Collaborator

There should only be one bridge feature in the above example, covering the entire extent of the bridge. The two blue highlighted sections do not have to be encoded as individual spans if the data producer does not wish to do so due to the statement "Span Fixed features should only be encoded if the span is entirely or partly over navigable water at the optimum display scale for the ENC data." - this is relevant to the spans only and not the bridge itself. However, because this is a "should" and not a "must" the producer may wish to encode the spans that are entirely over land for completeness.

The span information is the information relevant to the Mariner for navigation (clearances etc) so the spans are only required to be encoded where part of the span is over navigable water at the scale of the ENC.

The issue of how these bridges are converted from S-57 is problematic. Because of the extensive remodelling from S-57 to S-101 there is no "easy" way to convert. I do not consider that issues with data conversion should be considered when looking at how bridges are modelled in S-101.

@JeffWootton
Copy link
Collaborator

Discussed at S-101PT13. Current guidance considered to be sufficient. It is up to the Data producer to decide how to encode their Bridge features and their associated spans.

Close issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants