-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalogue and dataset versioning #10
Comments
From Tom Richardson: |
From Jonathan Pritchard: FC with version X.Y.Z+1 should also be backward compatible with X.Y.Z 100% but it becomes more murky when X.Y+1.* is defined. I would definitely welcome this being better defined and will review paper above. S100WG would be a good opportunity to get it sorted.... ah, I pressed send at the same time as @TomRichardson6 :-).. Agree needs better defn (and testing in S-164 - we have tests for multiple FC/Dataset versions but could use some work. v1.2 gives us something concrete to work with. |
From David Grant: @skjeves, it isn't necessary to add featureCatalogueVersion and portrayalCatalogueVersion to S100_ProductSpecification. S100_CatalogueDiscoveryMetadata already provides productSpecification and we had intended the S100_ProductSpecification productIdentifier field to uniquely identify a version of a product spec. The attribute could be used to tie the catalogs and datasets together, but the registry has yet to be updated to support this, and there is also no supporting test data; we had to proceed with an alternate implementation so that we could move on with testing. • Assign an MRN to each FC by adding an element to the FC. S100FC:mrnurn:mrn:iho:fc:...</S100FC:mrn> |
From Svein Skjaeveland: If I understand correctly the association between dataset and PC is not relevant - this is an indirect relationship defined in the FC. "it isn't necessary to add featureCatalogueVersion and portrayalCatalogueVersion to S100_ProductSpecification. S100_CatalogueDiscoveryMetadata already provides productSpecification and we had intended the S100_ProductSpecification productIdentifier field to uniquely identify a version of a product spec. The attribute could be used to tie the catalogs and datasets together, but the registry has yet to be updated to support this, and there is also no supporting test data; we had to proceed with an alternate implementation so that we could move on with testing". "We currently link datasets to FC's via the DSID/PRSP subfield in the 8211 encoding. In a GML encoding this would be the productIdentifier field (Table 10b-4), and in HDF-5 you could look at productSpecification (Table 10c-6). My understanding is that the FC version is supposed to align with the Product Spec version, although I don't think there is currently a written requirement we can reference. We establish a match when the first two version elements match. So, INT.IHO.S-101.1.1 matches FC 1.1.x, INT.IHO.S-101.1.2 matches FC 1.2.x, etc" If your preferred solution is assigning MRNs to FC and dataset encodings, I think you should propose it nevertheless. We have made other suggestions that has been determined not suitable before S-100 v6 - and although v5 will be used for production I guess continous development of the S-100 framework will take place eventually (especially based on all the topics still to be uncovered when people start implementing support for v5). |
Hi @skjeves, Please correct me if I am wrong. But this does not apply to the HDF5 product specifications. It would be important to me that the different data formats are taken into account in the considerations. I'm not interested in having the HDF5 product specifications changed simply because the S101 doesn't work properly. |
@RohdeBSH I think it applies also to the HDF5 prodspecs. The reference you refer to do not take into account the scenarios/use cases described earlier in this discussion: I would believe that also for HDF5 specs you could have similar changes to PC/FC that does not require an uptick in version numbering for DPS but only upticks the versioning of FC/PC (at least theoretical). |
I got that already, but I can't agree with your table. Ref. 4: Ref. 5: |
I also think the table has some errors. I agree with @RohdeBSH that:
I added a ref to account for editorial changes to the PS.
Notes:
|
@TomRichardson6 You provided the table initially, do you have any viewpoints on Daniels and Davids input? |
@skjeves sorry for the slow response here. The table was never fully discussed or finalized I propose that it is tabled again at S-101PT12 but ultimately this needs to be agreed for S-100/S-97 for consistency across all products. I do not agree with Daniel that the first two version elements must always be synchronous this means that despite the feature catalogue being machine readable a full major version of the product specification would be required to enable that meaning that the concept of making changes to the specifications using plug and play catalogues is not realized. Maybe I'm misunderstanding, the updated version provided by David seems reasonable to me. Obviously I'm hopeful that the S-100WG8 meeting resolved this and I missed that! |
My table incorporated Daniel's comments. I agree with him that the first two version numbers should be synchronized. See note 2 on the bottom of the table which explains why the version of the DPS must remain in sync:
Yes and no. My understanding is that they decided that all numbers should be synchronized. This is unrealistic because it requires updating everything anytime a correction needs to be made to any artifact. Alternatively, it promotes publication of corrections without updating the version number, which is a horrible idea. |
Thanks Dave well that's an awful approach and puts us back to where we were with S-57 before the UOC was unfrozen and for example would constrain changes to validation checks as we do now with S-58. I will look out for that in the actions and seek to challenge that. I'm concerned that some parties are still seeking to increase complexity here and this is reaching the point where S-57 ECDIS will end up looking much more attractive! I hope that's not the case. My hope is that through S-164 scenarios will be developed and tested which can then be used to validate the rules in the table. At the moment I expect to use S-101 1.1.0 and 1.2.0 data in the ShoreECDIS presented with the same PC, I see no logical reason why that should not be possible. I will seek to discuss this with JP. |
It's possible I misunderstood, but the versioning issue is something that certainly needs to be resolved ASAP. |
A PC is written with explicit knowledge of how the data model described by the FC is set up. Between the 1.1 and 1.2 FC there were wholesale changes to feature names and the relationships between associated feature/information types. The PC assumes that the data being fed into it was produced using a compatible FC. The PC has no way to discover if data was produced on a different FC. I suppose a context parameter could be added, but this would tremendously complicate PC development / maintenance. |
Hi guys,
I am preparing a paper related to dataset vs catalogue referencing for the upcoming S-100 meeting. Not sure to how large degree it is related to your discussion here, but I think there may be commonalities. If you would have a look it would be much appreciated. Do you agree this relationship is not covered yet in S-100 5.1.0, or have we missed something?
Catalogue and dataset versioning .docx
The text was updated successfully, but these errors were encountered: