Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-functional parameters of layout_with_kk() and layout_with_fr() #1108

Open
szhorvat opened this issue Jan 12, 2024 · 0 comments · May be fixed by #1628
Open

Remove non-functional parameters of layout_with_kk() and layout_with_fr() #1108

szhorvat opened this issue Jan 12, 2024 · 0 comments · May be fixed by #1628
Labels
lifecycle Deprecating old APIs
Milestone

Comments

@szhorvat
Copy link
Member

layout_with_kk() and layout_with_fr() used to use a completely different implementation / method in very old versions of igraph. R/igraph still has leftover non-functional parameters, which should be moved soon:

From the fr docs:

coolexp, maxdelta, area, repulserad | These arguments are not supported from igraph version 0.8.0 and are ignored (with a warning).

From the kk docs:

niter, sigma, initemp, coolexp | These arguments are not supported from igraph version 0.8.0 and are ignored (with a warning).

Additionally, kk has start, which should also be removed:

start | Deprecated synonym for coords, for compatibility.

CC @maelle

@krlmlr krlmlr added this to the upgrade-2 milestone Jan 13, 2024
@maelle maelle added the lifecycle Deprecating old APIs label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle Deprecating old APIs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants