Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'parent' instead of 'father' #880

Open
szhorvat opened this issue Aug 8, 2023 · 1 comment · May be fixed by #1523
Open

Use 'parent' instead of 'father' #880

szhorvat opened this issue Aug 8, 2023 · 1 comment · May be fixed by #1523
Assignees
@maelle
Labels
lifecycle Deprecating old APIs

Comments

@szhorvat
Copy link
Member

szhorvat commented Aug 8, 2023

The father vector, used by the dfs and bfs functions, should be renamed to parent to line up with standard nomenclature. Doing so will be breaking change, so some mitigation may be necessary.
@szhorvat szhorvat added this to the upgrade milestone Aug 8, 2023
@szhorvat
Copy link
Member Author

szhorvat commented Jan 2, 2024

@krlmlr This is an argument renaming, perhaps non-essential for 2.0.0. Do you want to remove it from the upgrade milestone?

@krlmlr krlmlr removed this from the upgrade milestone Jan 2, 2024
@krlmlr krlmlr added the lifecycle Deprecating old APIs label Feb 20, 2024
@maelle maelle linked a pull request Sep 23, 2024 that will close this issue
Open
@maelle maelle self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maelle maelle

Labels
lifecycle Deprecating old APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use 'parent' instead of 'father' in bfs() and dfs() igraph/rigraph
3 participants
@szhorvat @krlmlr @maelle