-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added translations for meetings and moments. #1256
Merged
toryalsip
merged 15 commits into
ifmeorg:ja-translations
from
toryalsip:ja-yml-meetings-and-moments
Nov 12, 2018
Merged
Added translations for meetings and moments. #1256
toryalsip
merged 15 commits into
ifmeorg:ja-translations
from
toryalsip:ja-yml-meetings-and-moments
Nov 12, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kapipan <[email protected]>
toryalsip
commented
Nov 9, 2018
nshki
requested changes
Nov 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left my comments.
Co-Authored-By: matcha440 <[email protected]>
Co-Authored-By: matcha440 <[email protected]>
Co-Authored-By: matcha440 <[email protected]>
Co-Authored-By: matcha440 <[email protected]>
Co-Authored-By: matcha440 <[email protected]>
Co-Authored-By: matcha440 <[email protected]>
Co-Authored-By: matcha440 <[email protected]>
Co-Authored-By: matcha440 <[email protected]>
Co-Authored-By: matcha440 <[email protected]>
Co-Authored-By: matcha440 <[email protected]>
Co-Authored-By: matcha440 <[email protected]>
Can't help at all with these translations hahaha, but just wanted to swing by and say this is looking awesome. Thank you for working on this everyone! |
nshki
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Next round of Japanese translations - Meetings and Moments.
Corresponding Issue
#1215
Test Coverage
✅