Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translations for meetings and moments. #1256

Merged
merged 15 commits into from
Nov 12, 2018
Merged

Added translations for meetings and moments. #1256

merged 15 commits into from
Nov 12, 2018

Conversation

toryalsip
Copy link
Contributor

@toryalsip toryalsip commented Nov 9, 2018

Description

Next round of Japanese translations - Meetings and Moments.

Corresponding Issue

#1215

Test Coverage

@toryalsip toryalsip self-assigned this Nov 9, 2018
@toryalsip toryalsip requested a review from nshki November 9, 2018 00:22
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
Copy link
Member

@nshki nshki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left my comments.

config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
@julianguyen
Copy link
Member

Can't help at all with these translations hahaha, but just wanted to swing by and say this is looking awesome. Thank you for working on this everyone!

@toryalsip toryalsip merged commit a3af582 into ifmeorg:ja-translations Nov 12, 2018
@toryalsip toryalsip deleted the ja-yml-meetings-and-moments branch November 12, 2018 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants