Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do if no CoRIM are selected? #356

Open
thomas-fossati opened this issue Jan 8, 2025 · 7 comments
Open

What to do if no CoRIM are selected? #356

thomas-fossati opened this issue Jan 8, 2025 · 7 comments

Comments

@thomas-fossati
Copy link
Collaborator

          I think this requirement should be removed actually. There are cases where you verify evidence purely through policy and no corims. You just trivially go from phase 1 to phase 5

We should be clear about the interface between the CoRIM verifier and the rest of the Appraisal stages. Then, we can re-introduce a normative sentence explaining what is expected in such case.

Originally posted by @deeglaze in #355 (comment)

@steven-bellock
Copy link
Collaborator

As I said here there can/should be at least two specifications:

  1. A standalone CoRIM-as-a-file-format (CDDL and all that) specification.
  2. A RATS-approved Verifier specification that may (but does not have to) operate on CoRIMs.

@nedmsmith
Copy link
Collaborator

Originally corim was "just" a format spec, but questions were raised about whether or not the appraisal process would work. Maybe something was missing or something was extraneous. This led to the internal representation schema and the transformation layer etc. Now that this is in place possibly it makes sense to separate them? However, they are tightly coupled in terms of the cddl that is used, so you would need to progress them in lock step if separate. Separating them would require WG adoption which will add a procedural component for not much benefit.

@deeglaze
Copy link
Collaborator

Agree with Ned here. The TCG spec for DICE endorsements coming to IETF to specify general endorsements significantly delayed the spec due to expanded scope. A new I-D for a general attestation verifier independent of CoRIM has the risk of a similar feature creep and delay.

@steven-bellock
Copy link
Collaborator

If that's the case then there are two specifications in one, and care should be taken to clearly delineate CoRIM-as-a-file-format and the Verifier. For the most part that's already in place but it's good to be aware of it. In addition the abstract and introduction should be expanded to include the Verifier portion. In particular it is now more than

This document specifies the information elements for representing Endorsements and Reference Values in CBOR format.

@yogeshbdeshpande
Copy link
Collaborator

I think, we need to add suitable section to Verifier processing where absence of CoRIM use case is also adequately covered!

@nedmsmith
Copy link
Collaborator

The short answer is Evidence claims end up in ACS. If nothing else is added as a result of no Reference Values or Endorsements. The ACS is what it is as it enters Phase 5+.

@yogeshbdeshpande
Copy link
Collaborator

Yes, we need to cover that case, where Policy may just dictate : Verify signature on Evidence and be just done with Appraisal !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants