You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When trying to use :'<,'>gq to wrap doc comments (||| leader) the comment leader is not created on new lines, and may actually be treated as a word and joined into a previous, short line.
In addition, when pressing <Enter> in insert mode when inside a doc comment, the comment lead isn't inserted.
This seems related to e8563c4 which overwrites comments and formatoptions that are set in the main ftplugin/idris.vim with clearly inferior versions. But, based on the commit message was meant to help limit the surface area of a security issue.
case Has the underlying security issue been addressed completely?
Yes good -> Would a patch removing comments and formatoptions from the after script be accepted?
No still_vulnerable -> Anyone have a sketch of what needs to change to address the vulnerability? Do we need more shellescape calls somewhere? <|> Left (still_vulnerable ?exploit)
When trying to use
:'<,'>gq
to wrap doc comments (|||
leader) the comment leader is not created on new lines, and may actually be treated as a word and joined into a previous, short line.In addition, when pressing
<Enter>
in insert mode when inside a doc comment, the comment lead isn't inserted.This seems related to e8563c4 which overwrites
comments
andformatoptions
that are set in the mainftplugin/idris.vim
with clearly inferior versions. But, based on the commit message was meant to help limit the surface area of a security issue.case Has the underlying security issue been addressed completely?
Yes good -> Would a patch removing
comments
andformatoptions
from the after script be accepted?No still_vulnerable -> Anyone have a sketch of what needs to change to address the vulnerability? Do we need more shellescape calls somewhere? <|> Left (still_vulnerable ?exploit)
@raichoo
The text was updated successfully, but these errors were encountered: