Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc comments are not formatted correctly #65

Open
stephen-smith opened this issue Apr 9, 2017 · 1 comment
Open

Doc comments are not formatted correctly #65

stephen-smith opened this issue Apr 9, 2017 · 1 comment

Comments

@stephen-smith
Copy link
Contributor

When trying to use :'<,'>gq to wrap doc comments (||| leader) the comment leader is not created on new lines, and may actually be treated as a word and joined into a previous, short line.

In addition, when pressing <Enter> in insert mode when inside a doc comment, the comment lead isn't inserted.

This seems related to e8563c4 which overwrites comments and formatoptions that are set in the main ftplugin/idris.vim with clearly inferior versions. But, based on the commit message was meant to help limit the surface area of a security issue.

case Has the underlying security issue been addressed completely?
Yes good -> Would a patch removing comments and formatoptions from the after script be accepted?
No still_vulnerable -> Anyone have a sketch of what needs to change to address the vulnerability? Do we need more shellescape calls somewhere? <|> Left (still_vulnerable ?exploit)

@raichoo

@stephen-smith
Copy link
Contributor Author

4702dd3 is the fix I am proposing; works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant