Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark CBool #172

Open
curiousleo opened this issue Jun 23, 2020 · 1 comment
Open

Benchmark CBool #172

curiousleo opened this issue Jun 23, 2020 · 1 comment

Comments

@curiousleo
Copy link
Collaborator

CBool is not being benchmarked right now in bench/Main.hs.

Just like the CBool tests, those benchmarks probably need to be guarded by

#if __GLASGOW_HASKELL >= 802
...
#endif
@lehins
Copy link
Collaborator

lehins commented Jun 23, 2020

@curiousleo I don't think adding more CPP is a good idea here. Benchmarking and testing another newtype wrapper around Word8 will not buy us that much for it too be worth it.

Both of its implementation and definition is identical to CUChar, so if anyone would like to see the numbers they can look at that type instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants