-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reunion with jupyter-server-proxy #28
Comments
Hi there! Thanks for getting in touch. I don't personally have any plans for any of this, but happy to accept a PR here if you want to incorporate UNIX sockets or similar, and I can issue a release. But if you (or others) are interested in carrying out the refactoring of jupyter-server-proxy so that it can be used as a replacement for jhsingle-native-proxy then that would be preferable and more likely to be actively maintained in the longer term. |
Thanks for your fast response. IMHO it would be best to integrate the standalone feature into But I assume this Repo will persist, just because of all the customizations for ContainDS Dashboards, right? |
Great, thanks for letting us know.
As far as I'm concerned this repo will persist, but I don't have any
personal plans to work on it at present.
Thanks,
Dan
…On Tue, 17 Sept 2024 at 15:33, Jonathan Windgassen ***@***.***> wrote:
Thanks for your fast response.
IMHO it would be best to integrate the standalone feature into
jupyter-server-proxy, as I have started in the PR I linked above. As it
sounds to me, you are welcoming this usage of your code, so I would just
continue with it. I will, of course, mention this project in the code and
docs to indicate, where it has originated from :)
But I assume this Repo will persist, just because of all the
customizations for *ContainDS Dashboards*, right?
—
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF76PUFQPRL6QA5LGISS5TZXA4R3AVCNFSM6AAAAABOI5S7XCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJWGAZTMOBVGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Dan Lester
***@***.***
https://www.linkedin.com/in/lesterdan/
|
Hello there.
We have been exploring this repository and are very interested in the possibility of hosting standalone proxies in JupyterHub. But unfortunately, we noticed that the original proxy implementation has moved away from the one in
jupyter-server-proxy
and does not currently support Unix sockets, for example (#24).We think, that the feature this repository provides (perhaps a bit slimmed down, without the customizations for ContainDS dashboards) would be a great addition to the original repository. The folks there also had this idea some time ago and would certainly welcome the addition (jupyterhub/jupyter-server-proxy#1)
I'm contacting you to see what you plan to do with this repository and if you have further plans for it. I already started integrating the feature into JSP a few days ago and created a proof of concept for the merge. Although I didn't manage to get it fully up and running, I already opened a PR and tried to discuss this integration there: jupyterhub/jupyter-server-proxy#501.
I think there is definitely room for discussion on how the merge of
jhsingle-native-proxy
andjupyter-server-proxy
should be done, especially given the requirements and customizations that exist here. Please let me know your opinions and thoughts, or directly participate in the discussion in the PR over there.The text was updated successfully, but these errors were encountered: