Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiry of issuer's auth claim is not checked #96

Open
nedgar opened this issue Jun 12, 2023 · 2 comments
Open

Expiry of issuer's auth claim is not checked #96

nedgar opened this issue Jun 12, 2023 · 2 comments

Comments

@nedgar
Copy link

nedgar commented Jun 12, 2023

Looking through the query circuits, I see that they check the base claim's expiry, but not the auth claim's. Should they?

I know that in the example scenarios the auth claims are always self-issued, with no expiry. But is it possible for auth claims to be issued by another party, with an expiry?

https://github.com/search?q=repo%3Aiden3/circuits%20verifyExpirationTime&type=code

@nedgar
Copy link
Author

nedgar commented Jun 12, 2023

FYI @OBrezhniev

@OBrezhniev
Copy link
Member

Hi @nedgar! Auth claims must be self-issued and only using claims merkle tree. But in general auth claim expiration could be an interesting feature, we may consider adding the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants