Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto.js is future hostile #3

Closed
rwaldron opened this issue Oct 22, 2014 · 6 comments
Closed

proto.js is future hostile #3

rwaldron opened this issue Oct 22, 2014 · 6 comments

Comments

@rwaldron
Copy link
Contributor

https://github.com/ideino/ideino-linino-lib/blob/master/utils/proto.js

These should be defined conditionally and done so to match the spec.

https://people.mozilla.org/~jorendorff/es6-draft.html#sec-string.prototype.startswith
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-string.prototype.endswith

Array.prototype.contains is contentious, but I would implement the proposed spec:

https://github.com/domenic/Array.prototype.contains

@quasto
Copy link
Contributor

quasto commented Oct 27, 2014

all the functions in this file are never used in the library code. these have been written just for development comfort.

about the emacs spec for startsWith and endsWith what do you think about these implementations?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/endsWith

thank you
quasto

@quasto quasto reopened this Oct 27, 2014
@rwaldron
Copy link
Contributor Author

*Ecma

Those are fine, but I recommend using the es6-shim module, which is spec correct and well tested.

@quasto
Copy link
Contributor

quasto commented Oct 27, 2014

this one?
https://github.com/paulmillr/es6-shim/

@rwaldron
Copy link
Contributor Author

Yes

@quasto
Copy link
Contributor

quasto commented Oct 28, 2014

perfect, i updated. thank you rick.

@quasto quasto closed this as completed Oct 28, 2014
@rwaldron
Copy link
Contributor Author

Glad to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants