Fixed an issue with the analytical solution for problem val-1d.

[humrickhouse]

The diffusion coefficient in the analytical solution was incorrect; it has been re-set to 1.0 and TMAP8 is now in excellent agreement with the solution. Also updated the documentation to reflect changes to equation 7 from the original TMAP4 V&V report that were never completely propagated through to values and symbols in the accompanying text.

Refs #12

[lindsayad]

@humrickhouse love the pull request! The failure you're getting on the pre-check is because each pull request needs at least one commit that references an issue. As an example you can look at @singhgp4321's commit 227a3cc

You can either create a new issue or reference an existing issue. To edit your commit message, you can run

git commit --amend

[cticenhour]

Thanks Alex! I had already mentioned this to Paul on Slack after he reached out to Gyan and myself. Should have mentioned something here after I made the review request.

[humrickhouse]

Ok got the issue reference in there.

[moosebuild]

Job Documentation on f4c816c wanted to post the following:

View the site here

This comment will be updated on new commits.

[cticenhour]

Dis-regard this review. Testing permissions.

Invalid test review

[singhgp4321]

@humrickhouse Your changes look good. Could you also add the updated figure (val-1d_comparison_diffusion.png) for the comparison under doc/content/verification/figures?

[humrickhouse]

I can... is there a reason not to use symlinks from the documentation to the testing directory, so the documentation is updated automatically when the tests are run?

[singhgp4321]

I can... is there a reason not to use symlinks from the documentation to the testing directory, so the documentation is updated automatically when the tests are run?

In my knowledge we are not doing the automatic update - currently the documentation plots have to be updated manually. @lindsayad can correct me if that's not the case.

[lindsayad]

so the documentation is updated automatically when the tests are run?

I don't quite know what is meant by this. We do not run any python scripts automatically when the val-1d test suite is run, although we could. If we added python unit tests to the val-1d associated tests, then I think some symlinks would make sense

[lindsayad]

@singhgp4321 you want to take a final run-through on this? If it looks good, feel free to approve and merge