Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and Update val-2b #202

Merged
merged 13 commits into from
Oct 31, 2024
Merged

Clean up and Update val-2b #202

merged 13 commits into from
Oct 31, 2024

Conversation

simopier
Copy link
Collaborator

(Ref. #12)
(Close. #80)

@simopier simopier added the V&V Relevant to V&V label Oct 27, 2024
@simopier simopier self-assigned this Oct 27, 2024
@moosebuild
Copy link

moosebuild commented Oct 27, 2024

Job Documentation, step Sync to remote on 3cd3926 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

moosebuild commented Oct 27, 2024

Job Coverage, step Generate coverage on 3cd3926 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

@simopier simopier mentioned this pull request Oct 30, 2024
Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments. Please rebase to correct the merge conflict. Thanks!

doc/content/verification_and_validation/val-2b.md Outdated Show resolved Hide resolved
test/tests/val-2b/comparison_val-2b.py Outdated Show resolved Hide resolved
test/tests/val-2b/comparison_val-2b.py Outdated Show resolved Hide resolved
test/tests/val-2b/tests Outdated Show resolved Hide resolved
test/tests/val-2b/tests Outdated Show resolved Hide resolved
doc/content/verification_and_validation/val-2b.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/val-2b.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/val-2b.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/val-2b.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/val-2b.md Outdated Show resolved Hide resolved
simopier and others added 12 commits October 30, 2024 17:05
- remove old csv files
- create new tests, including heavy and light, with csv and exodus
… for csvdiff since it is expected to be close to 0.
- resolve conflicts
- improve documentation
- remove csv tests for regression
- remove unecessary .exodiff file (no need since the length unit was updated)
@cticenhour cticenhour merged commit ced9a40 into devel Oct 31, 2024
8 checks passed
@simopier simopier deleted the TMAP8_val-2b branch October 31, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V&V Relevant to V&V
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants