-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ver 1jb to TMAP8's V&V suite #185
Conversation
Job Documentation, step Sync to remote on 6eee844 wanted to post the following: View the site here This comment will be updated on new commits. |
EDIT:this issue was solved. It came from the fact that both tests added in this case were writing checkpoint files with the same name. Hence, depending on the timeline in which This PR is fully ready for review. Somehow, the recover test for the basic ver-1jb csv diff case fails. in the normal test, I locally get:
but when I run in recover mode, I get:
and the time step ends up being different. To be even more confusing, the case with equivalent concentrations of mobile and trapped tritium runs well in recover mode, when the only difference is the initial concentration of mobile tritium and trap_per_free value. Any ideas or suggestions @cticenhour, @chaibhave, @lin-yang-ly? Despite this issue, this PR is ready for review. |
- decay term for trapped tritium - use unit system - update comments
- add case with equivalent concentrations of mobile and trapped tritium
…erate test, increase accuracy, and fix recover failure
This should solve the recover issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically good to go except for some documentation and python code changes.
Co-authored-by: Chaitanya Bhave <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a review, just responses to @chaibhave's comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cticenhour ready for your review, I'm done with all reviews. The comments left unresolved you can resolve, I'm not on the CCB yet so I don't have permissions for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few items I'd like addressed, and I resolved the remaining comments from @chaibhave that were marked as completed.
Co-authored-by: Casey Icenhour <[email protected]>
helium-3 to $^3$He for consistency.
Ref. #12
Ref. #145