-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ver 1ka #183
Ver 1ka #183
Conversation
@Lee01Atom see my emails on how to clean this up. If that doesn't work, let me know. |
Job Documentation, step Sync to remote on b0b0668 wanted to post the following: View the site here This comment will be updated on new commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments (to add to the outstanding remaining comments in #178) to reduce the computational time of the test.
Co-authored-by: Pierre-Clement Simon <[email protected]>
@simopier the Test/Test Debug seems to work. There is still an issue with the Documentation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements, @Lee01Atom!
I left several comments throughout, and the main one for the documentation is the command for the alias.
Let me know if you have any questions.
Note to self: I will still need to review the documentation once it builds.
doc/content/verification_and_validation/figures/comparison_ver-1ka.py
Outdated
Show resolved
Hide resolved
See a suggestion in my latest review above. Let me know if you're running into issues.
|
doc/content/verification_and_validation/figures/comparison_ver-1ka.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Pierre-Clement Simon <[email protected]>
doc/content/verification_and_validation/figures/comparison_ver-1ka.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Pierre-Clement Simon <[email protected]>
You are getting:
|
Co-authored-by: Pierre-Clement Simon <[email protected]>
Co-authored-by: Pierre-Clement Simon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the python script
Co-authored-by: Pierre-Clement Simon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments for the documentation
Co-authored-by: Pierre-Clement Simon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some last suggestions (I should have added those earlier but I missed this), and then you're good to go!
Co-authored-by: Pierre-Clement Simon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations for your first contributions, @Lee01Atom!
(Ref. #12)
EDIT: for your next PR, @Lee01Atom, you should list the issue number here too, just like I added above.