-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make verification = '**.md' consistent across verification cases #165
Conversation
Job Documentation on 77aa677 wanted to post the following: View the site here This comment will be updated on new commits. |
Wait. The CI-generated VVR doesn't have these listed....I need to explore why before this can be merged. https://mooseframework.inl.gov/tmap8/docs/PRs/165/site/sqa/tmap8_vvr.html |
New information precludes approval at this time.
@cticenhour - just a gentle ping. |
Thanks for the reminder - I will get to this when I return next week. Maybe Thursday afternoon at the earliest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I know what's going on here now. I am working on an issue for MOOSE so that I work on adjusting behavior in MooseDocs. In the meantime, here's what's up:
The verification
and validation
parameters need to go down into each test spec, individually, rather than live at the top-level. This is because, as currently designed, one verification document was assumed to pair with one test specification. Given we tend to have multiple tests correspond to a single verification case, this assumption is a poor one for our needs. I will fix it. In the meantime, to close this PR, please restore what was done in ver-1d
and then emulate that in all other V&V tests. Then I can open a new PR at a later time to make this cleaner once my adjustments are merged into MOOSE.
EDIT: We have decided to wait until the fix is in MOOSE to approach this PR again.
MOOSE PR is idaholab/moose#28916 EDIT: Merged in just now (2024-Oct-23, 4:30PM MT), but will take a few hours before it makes it into the submodule. I will let you know when we can re-trigger testing. |
Job Documentation on 77aa677 : invalidated by @simopier Restarting this now After MOOSE's SQA update |
@cticenhour I just restarted the documentation tests. |
Job Documentation, step Sync to remote on 7ff5c44 wanted to post the following: View the site here This comment will be updated on new commits. |
This could be merged in, because it doesn't break anything, but won't take full effect until what is in moose next makes it to moose master. Next is blocked last I checked. |
Job Documentation on 77aa677 : invalidated by @cticenhour SQA changes now in MOOSE submodule in TMAP8 |
@simopier I think you need to rebase on top of current devel to get this to work properly. An invalidation doesn't seem to be enough. |
77aa677
to
7ff5c44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the MOOSE fix, the VVR in the doco preview now shows all verification cases selected in this PR. Looks good!
(Ref. #12)