Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VV tests #12

Open
3 of 4 tasks
lindsayad opened this issue Jun 16, 2021 · 2 comments
Open
3 of 4 tasks

VV tests #12

lindsayad opened this issue Jun 16, 2021 · 2 comments
Assignees
@simopier
Labels
T: Task An enhancement to the software. V&V Relevant to V&V

Comments

@lindsayad
Copy link
Member

lindsayad commented Jun 16, 2021 •
edited by simopier
Loading

We want to make sure that we've at least covered the VV tests from TMAP4. I believe that @simopier indicated he has some more VV tests to add as well. We should also add documentation for this so that users can view it on our website

  • Make sure we have verification parameter filled in for all val tests and linking to .md files for each (currently missing val-1a, val-1b, val-1c)
  • Fill in incomplete val-1d.md sections
  • Add remaining TMAP4/TMAP7 VV tests that we don't yet have
  • Check into discrepancy with analytical result for val-1d verification

@simopier: EDIT - Adding the full list of TMAP4 and TMAP7 V&V cases with names of who's working on which. This is meant to facilitate coordination.

Case name​ Case description Status or name
ver-1a​ Depleting Source Problem​ ✅
ver-1b​ Diffusion Problem with Constant Source Boundary Condition​ ✅
ver-1c​ Diffusion Problem with Partially Preloaded Slab​​ ✅
ver-1da​ Permeation Problem with Trapping​​ ✅
ver-1dd​ No Trapping (7)​​ ✅
ver-1dc​ Multiple Trap (7)​​ ✅
ver-1dd Permeation Problem without Trapping​​ ✅
ver-1e​ Diffusion in Composite Material Layers​​ ✅
ver-1fa​ Heat Conduction with Heat Generation​​ ✅
ver-1fb​ Thermal Transient​​ ✅
ver-1fc​ Conduction in Composite Structure with Constant Surface Temperatures​​ ✅
ver-1fd​ Convective Heating​​ ✅
ver-1g​ Simple Forward Chemical Reaction​​ ✅
ver-1gc​ Series Chemical Reactions​​ ✅
ver-1ha​ Convective Gas Outflow Problem​​ ✅
ver-1hb​ Equilibrating Enclosures (7)​​ ✅
ver-1ia​ Species Equilibration on a Reactive Surface - a (7)​ ✅
ver-1ib​ Species Equilibration on a Reactive Surface - b (7)​ ✅
ver-1ic​ Species Equilibration on a Reactive Surface - c (7)​ ✅
ver-1id​ Species Equilibration on a Reactive Surface - d (7)​ ✅
ver-1ie​ Species Equilibration on a Reactive Surface - e (7)​ ✅
ver-1if​ Species Equilibration on a Reactive Surface - f (7)​ ✅
ver-1ja​ Radioactive Decay of Mobile Tritium in a Slab​ ✅
ver-1jb​ Radioactive Decay of Mobile Tritium in a Slab with a Distributed Trap Concentration (7)​​ ✅
ver-1ka​ Enclosure Volumetric Source Rate - Simple (7)​ ✅
ver-1kb​ Enclosure Volumetric Source Rate - Henry (7)​ ✅
ver-1kc​ Enclosure Volumetric Source Rate - Sieverts 1 (7)​ @Lee01Atom @simopier
ver-1kd​ Enclosure Volumetric Source Rate - Sieverts 2 (7)​ @Lee01Atom @simopier
val-2a​ Ion Implantation Experiment (4+7)​​ ✅
val-2ba​ Diffusion Experiment in Beryllium​​ ✅
val-2bb​ Diffusion Experiment in Beryllium​​ ✅
val-2c​ Test Cell Release Experiment (4+7)​​ ✅
val-2d​ Thermal Desorption Spectroscopy on Tungsten ()​​ @lin-yang-ly
val-2e​ Co-permeation of H2 and D2 through Pd​​ @ke7kto

@chaibhave is also working on defining standards for the TMAP8 V&V cases, which will need to be followed: #123.
@simopier
Copy link
Collaborator

The manual for TMAP7 describes more VV tests than the manual for TMAP4. It's a good place to look at!

@singhgp4321 singhgp4321 mentioned this issue Mar 22, 2022
Merged
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Mar 28, 2022
@singhgp4321
Documentation for validation cases 1-3 idaholab#12
fabe6ec
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Mar 28, 2022
@singhgp4321
Documentation for validation cases 1-3 idaholab#12
503c81d
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Mar 28, 2022
@singhgp4321
Documentation for validation cases 1-3 idaholab#12
99f0103
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Mar 28, 2022
@singhgp4321
Documentation for validation cases 1-3 idaholab#12
a38ea6a
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Mar 29, 2022
@singhgp4321
Documentation for validation cases 1-3 idaholab#12
65d60a5
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Apr 14, 2022
@singhgp4321
Documentation for validation cases 1-3 idaholab#12
ede79d9
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Apr 14, 2022
@singhgp4321
Documentation for validation cases 1-3 idaholab#12
0717b24
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Apr 14, 2022
@singhgp4321
Documentation for validation cases 1-3 idaholab#12
8e4056e
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Apr 14, 2022
@singhgp4321
Documentation for validation cases 1-3 idaholab#12
4d258bf
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Apr 14, 2022
@singhgp4321
Documentation for validation cases 1-3 idaholab#12
8900cea
@lindsayad
Copy link
Member Author

@singhgp4321 feel free to check off the task list items in the title post of this issue if/as you address them

@singhgp4321 singhgp4321 mentioned this issue Jul 30, 2022
Merged
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Jul 30, 2022
@singhgp4321
Adding val-1e case
5f22b5c 
Ref: idaholab#12
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Aug 1, 2022
@singhgp4321
Adding val-1fa and val-1fb verification cases idaholab#12
0a57ee0
@singhgp4321 singhgp4321 mentioned this issue Aug 1, 2022
Merged
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Aug 1, 2022
@singhgp4321
Adding val-1fa and val-1fb verification cases idaholab#12
86a849c
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Aug 1, 2022
@singhgp4321
Adding val-1fa and val-1fb verification cases idaholab#12
798fdac
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Aug 2, 2022
@singhgp4321
Adding val-1fa and val-1fb verification cases idaholab#12
b34d2e0
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Aug 2, 2022
@singhgp4321
Adding val-1fa and val-1fb verification cases idaholab#12
227a3cc
humrickhouse added a commit to humrickhouse/TMAP8 that referenced this issue Aug 15, 2022
@humrickhouse
Fixed an issue with the analytical solution for problem val-1d (Refs i…
1415a48 
…daholab#12).  TMAP8 is now in excellent agreement with the solution.  Also updated the documentation to reflect changes to equation 7 from the original TMAP4 V&V report that were never completely propagated through to values and symbols in the accompanying text.
@cticenhour cticenhour mentioned this issue Aug 15, 2022
Merged
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Aug 16, 2022
@singhgp4321
Adding val-1fa and val-1fb verification cases idaholab#12
1aed3b0
humrickhouse added a commit to humrickhouse/TMAP8 that referenced this issue Sep 13, 2022
@humrickhouse
Fixed an issue with the analytical solution for problem val-1d (Refs i…
f4c816c 
…daholab#12).  TMAP8 is now in excellent agreement with the solution.  Also updated the documentation to reflect changes to equation 7 from the original TMAP4 V&V report that were never completely propagated through to values and symbols in the accompanying text.  Updated comparison figures have been added to the documentation.
humrickhouse added a commit to humrickhouse/TMAP8 that referenced this issue Sep 21, 2022
@humrickhouse
Added SolubilityRatioMaterial to handle dissimilar solid material int…
7b6d2af 
…erfaces ('linked segments' in legacy TMAP parlance). Also added problem val-2d (Refs idaholab#12) though it isn't working yet, and the digitized experiment data and python script needed to make the comparison figure.
simopier added a commit that referenced this issue Oct 25, 2022
@simopier
Change the naming from 'Validation' to 'Verification for relevant cases.
bc0f6da 
The current documentation and file naming list verification cases as validation cases. This PR changes that for relevant cases.
This PR therefore does not add any new feature/V&V cases, only renames existing cases and updates the documentation.
(Ref. #12)
@simopier simopier mentioned this issue Oct 25, 2022
Merged
simopier added a commit that referenced this issue Oct 25, 2022
@simopier
Change the naming from 'Validation' to 'Verification for relevant cases.
94af93a 
The current documentation and file naming list verification cases as validation cases. This PR changes that for relevant cases.
This PR therefore does not add any new feature/V&V cases, only renames existing cases and updates the documentation.
(Ref. #12)
singhgp4321 added a commit to singhgp4321/TMAP8 that referenced this issue Oct 31, 2022
@singhgp4321
Adding val-1e case
e0224d1 
Ref: idaholab#12
@simopier simopier mentioned this issue Sep 8, 2024
Merged
@simopier simopier mentioned this issue Sep 24, 2024
Closed
Lee01Atom pushed a commit to Lee01Atom/TMAP8 that referenced this issue Sep 25, 2024
add ver-1ka
389f14e 
(Ref. idaholab#12)
Lee01Atom pushed a commit to Lee01Atom/TMAP8 that referenced this issue Oct 1, 2024
delete_trailing_whitespace.sh
5ecb754 
(Ref. idaholab#12)
Lee01Atom pushed a commit to Lee01Atom/TMAP8 that referenced this issue Oct 4, 2024
(Ref. idaholab#12)
b669053
Lee01Atom pushed a commit to Lee01Atom/TMAP8 that referenced this issue Oct 4, 2024
(Ref. idaholab#12)
48fb0ac
@simopier simopier mentioned this issue Oct 4, 2024
Merged
@simopier simopier mentioned this issue Oct 13, 2024
Merged
simopier added a commit that referenced this issue Oct 13, 2024
@simopier
ver-1d and ver-1ja clean up prompted by ver-1jb case development
6b7fcb7 
(Close. #145)
(Ref. #12)
@simopier simopier mentioned this issue Oct 15, 2024
Merged
simopier added a commit that referenced this issue Oct 15, 2024
@simopier
ver-1d and ver-1ja clean up prompted by ver-1jb case development
a71df96 
(Close. #145)
(Ref. #12)
simopier added a commit that referenced this issue Oct 23, 2024
@simopier
Add val-2c in TMAP8 V&V
95ffc57 
(Ref. #12)
simopier added a commit that referenced this issue Oct 23, 2024
@simopier
Clean up:
2536655 
- add #12 as issue number
- increase figure resolution
simopier added a commit that referenced this issue Oct 23, 2024
@simopier
Add val-2c in TMAP8 V&V
cc1fd65 
(Ref. #12)
simopier added a commit that referenced this issue Oct 23, 2024
@simopier
Clean up:
cdd5c5f 
- add #12 as issue number
- increase figure resolution
@simopier simopier mentioned this issue Oct 23, 2024
Merged
simopier added a commit that referenced this issue Oct 25, 2024
@simopier
Make verification = '**.md' consistent across verification cases
7ff5c44 
(Ref. #12)
Lee01Atom added a commit to Lee01Atom/TMAP8 that referenced this issue Oct 25, 2024
@Lee01Atom
(Ref. idaholab#12)
06038bc
@Lee01Atom Lee01Atom mentioned this issue Oct 26, 2024
Merged
simopier added a commit that referenced this issue Oct 27, 2024
@simopier
Update input file for val-2b
fcf4308 
(Ref. #12)
(Close. #80)
@simopier simopier mentioned this issue Oct 27, 2024
Merged
simopier added a commit that referenced this issue Oct 30, 2024
@simopier
Update input file for val-2b
3e924ad 
(Ref. #12)
(Close. #80)
@lin-yang-ly lin-yang-ly mentioned this issue Nov 1, 2024
Draft
@simopier simopier mentioned this issue Nov 4, 2024
Merged
simopier added a commit that referenced this issue Nov 17, 2024
@simopier
Update and clean up V&V documentation
38cd0ab 
(Ref. #12)
simopier added a commit that referenced this issue Nov 21, 2024
@simopier
Update failing heavy tests
1a5fb19 
(Ref. #12)
@simopier simopier mentioned this issue Nov 21, 2024
Merged
Lee01Atom added a commit to Lee01Atom/TMAP8 that referenced this issue Nov 26, 2024
@Lee01Atom
(Ref. idaholab#12)
681854b
@Lee01Atom Lee01Atom mentioned this issue Nov 26, 2024
Open
Lee01Atom added a commit to Lee01Atom/TMAP8 that referenced this issue Nov 26, 2024
@Lee01Atom
(Ref. idaholab#12)
0d23d1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simopier simopier

Labels
T: Task An enhancement to the software. V&V Relevant to V&V
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lindsayad @cticenhour @simopier