-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABCE plugin #277
Open
JiaZhou-PU
wants to merge
33
commits into
devel
Choose a base branch
from
abce
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ABCE plugin #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this still has more to be written (it is a WIP after all). I am curious what else needs to be done. Also, a test case might be useful for getting an idea for where this is going (even if it doesn't run yet). Thanks. |
* implementing capacity factors in Component input specs and get_capacity * some more comments for usage of cap factors * adding test for capacity factors, includes script to generate gold values * moving gold file one directory down so tests pass * cosmetic changes * allowing static histories for cap factors, also fixing usage of static hists as capacities * quick assert, capacities must all be positive OR negative * regolding with static history, new npp vom, moving golding script * new static histories for capacity factors test * reimplementing wind case using capacity factors, updating npp vom * updating simple wind workshop case, adding new case with storage * trying coarse optimization for both cases * switching back to sweeps, fewer values * updating tests file, regolding and new opt solutions added * better debug values * new analytic file showing plots, improved opt plots in gold
* Minor Changes & Slides * Change location of IES pptx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address?
Address #276
What are the significant changes in functionality due to this change request?
Add ABCE plugins for HERON
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.