Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABCE plugin #277

Open
wants to merge 33 commits into
base: devel
Choose a base branch
from
Open

ABCE plugin #277

wants to merge 33 commits into from

Conversation

JiaZhou-PU
Copy link
Collaborator


Pull Request Description

What issue does this change request address?

Address #276

What are the significant changes in functionality due to this change request?

Add ABCE plugins for HERON


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@joshua-cogliati-inl
Copy link
Collaborator

joshua-cogliati-inl commented Jun 19, 2023

I think this still has more to be written (it is a WIP after all). I am curious what else needs to be done. Also, a test case might be useful for getting an idea for where this is going (even if it doesn't run yet). Thanks.

JiaZhou-PU and others added 23 commits June 19, 2023 16:09
* implementing capacity factors in Component input specs and get_capacity

* some more comments for usage of cap factors

* adding test for capacity factors, includes script to generate gold values

* moving gold file one directory down so tests pass

* cosmetic changes

* allowing static histories for cap factors, also fixing usage of static hists as capacities

* quick assert, capacities must all be positive OR negative

* regolding with static history, new npp vom, moving golding script

* new static histories for capacity factors test

* reimplementing wind case using capacity factors, updating npp vom

* updating simple wind workshop case, adding new case with storage

* trying coarse optimization for both cases

* switching back to sweeps, fewer values

* updating tests file, regolding and new opt solutions added

* better debug values

* new analytic file showing plots, improved opt plots in gold
* Minor Changes & Slides

* Change location of IES pptx
@JiaZhou-PU JiaZhou-PU changed the title [WIP] initial test for abce ABCE plugin Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants