Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ClashingMemberRenamer incorrectly renames Enum types #1036

Merged
merged 5 commits into from
Oct 7, 2023
Merged

Conversation

Yozer
Copy link
Member

@Yozer Yozer commented Oct 5, 2023

Problem

Fixes #1035

Solution

  • Any comments on the approach taken, its consistency with surrounding code, etc.
  • Which part of this PR is most in need of attention/improvement?
  • At least one test covering the code changed

// few tests are failing, will take a look at them later...

Copy link
Member

@GrahamTheCoder GrahamTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The failing tests probably just assert the old behaviour, which we now know is unnecessary, so you can just run them with recharacterize set to true.

@Yozer
Copy link
Member Author

Yozer commented Oct 7, 2023

Yep, that's what I did.
I also compiled the new tests results to make sure that the not-renamed enum doesn't break them.

@Yozer Yozer merged commit fd6e10a into master Oct 7, 2023
2 checks passed
@Yozer Yozer deleted the fix-1035 branch October 7, 2023 15:41
@GrahamTheCoder
Copy link
Member

Hmm yes, good plan to check since I don't think the MultiFileCharacterization ones flag anywhere if the compilation of the result fails (whereas the normal ones output compile errors at the bottom of the output)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VB -> C#: ClashingMemberRenamer incorrectly renames Enum types
2 participants