Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI #26

Open
nya3jp opened this issue Jul 1, 2020 · 1 comment
Open

Set up CI #26

nya3jp opened this issue Jul 1, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@nya3jp
Copy link
Contributor

nya3jp commented Jul 1, 2020

Currently platform contributors verify Docker builds locally. This is probably okay before the contest, but I'm afraid that it's undesirable during the contest because any change to Dockerfiles may break other team's solutions.

It is great if we could set up CI to verify Dockerfiles on pull requests. It would do something like:

  • For each platform:
    • Build a base image with Dockerfile.base if it exists
    • Build one or more test solutions using Dockerfile and the base image, without network access
@beevee
Copy link
Member

beevee commented Jul 1, 2020

As mentioned in #25, we have an internal CI that continuosly checks all starterkit repos against current Dockerfiles. But not PRs, you're right. I will consider setting up CI, thank you!

@beevee beevee added the enhancement New feature or request label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants