Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PyPI failing due to accidental publishes from another branch #562

Closed
JessicaS11 opened this issue Aug 13, 2024 · 7 comments
Closed

Comments

@JessicaS11
Copy link
Member

JessicaS11 commented Aug 13, 2024

Since the transition to pyproject.toml(#539), we routinely get failures of the testPyPI action after it's merged into development (e.g. here):

 Uploading icepyx-1.1.1.dev11-py3-none-any.whl
WARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         File already exists. See https://test.pypi.org/help/#file-name-reuse   
         for more information.  

Anyone know why these are happening (even after #541)?

@mfisher87
Copy link
Member

mfisher87 commented Aug 13, 2024

Uploading icepyx-1.1.1.dev11-py3-none-any.whl ... File already exists

The file for dev11 was uploaded on August 12 -- our CI should be trying to upload dev12 instead, correct?

https://test.pypi.org/project/icepyx/1.1.1.dev11/

@mfisher87
Copy link
Member

mfisher87 commented Aug 13, 2024

Would you like to have a zoom chat tomorrow? I know you're preparing for the hack week and I want to take as much load off your plate on this as I can. Apologies for the inconvenience of whatever it was we missed here!

@weiji14
Copy link
Member

weiji14 commented Aug 13, 2024

Hmm, I'm looking at the publish_to_pypi.yml and see that the trigger should only be on pushes to the development branch, on release, or workflow_dispatch:

# Only run for tagged releases and pushes to the development branch
on:
release:
types:
- published
push:
branches:
- development
# Trigger manually at https://github.com/icesat2py/icepyx/actions/workflows/publish_to_pypi.yml
workflow_dispatch:

But the Actions tab is showing the workflow running on both development and v2 branches?

image

Did someone trigger the GitHub Action manually on the v2 branch? That could be why there were duplicate .devXX TestPyPI builds.

@mfisher87
Copy link
Member

Ahh shoot. Thanks for figuring that out! That was my mistake. I deliberately set some actions to run on the v2 branch, because it will be long-running, but I should not have done so with this action.

@JessicaS11
Copy link
Member Author

That could be why there were duplicate .devXX TestPyPI builds.

Thanks for figuring that out, @weiji14!

I deliberately set some actions to run on the v2 branch, because it will be long-running, but I should not have done so with this action.

Makes sense - I assume that if we disable this action from the ones you have running on v2 we'll be all set?

@mfisher87
Copy link
Member

Yes, I did that immediately when @weiji14 realized my mistake. Should be good going forward! Apologies all 😬

@mfisher87 mfisher87 changed the title Test PyPI failing since transition to pyproject.toml Test PyPI failing due to accidental publishes from another branch Aug 14, 2024
@mfisher87
Copy link
Member

I think we're good to close this as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants