Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace strings like Custom5, Custom3 with NAs #263

Open
lucalamoni opened this issue Nov 17, 2024 · 8 comments
Open

Replace strings like Custom5, Custom3 with NAs #263

lucalamoni opened this issue Nov 17, 2024 · 8 comments
Assignees

Comments

@lucalamoni
Copy link

lucalamoni commented Nov 17, 2024

This is one of the points we discussed at the meeting on the 24th of October.

Sometimes empty custom ref points and empty custom data columns in SAG have strings like Custom3, Custom5 etcc. Would it be possible to substitute these values with NAs?

@lucalamoni lucalamoni converted this from a draft issue Nov 17, 2024
@cmspinto cmspinto self-assigned this Nov 20, 2024
@cmspinto
Copy link
Collaborator

Does this issue occur during the download process, within the web services, or in both?

From what I can see, it seems the submitter did include those values. I don’t believe there’s any risk in removing them from the database, as we can always verify if there are values associated with those headings. However, could you clarify why it is important to remove these custom names?

@lucalamoni
Copy link
Author

both @Milldaz and me noticed this mostly in custom ref points names, here is an example below:
image
image
https://standardgraphs.ices.dk/ViewSourceData.aspx?key=18508
These custom ref point names don't seem to correspond to any value. Maybe there is a reason for this that I am not aware of.

@Milldaz
Copy link
Collaborator

Milldaz commented Nov 25, 2024

Yes, this is a template error (the template has these names pre-filled). I think we should scan through the database and delete all Custom Ref Pts with those names and no value associated with it.

@cmspinto
Copy link
Collaborator

Hi, I have done a query in the database and there are 5 stocks where this happened, here is the list of the of the stocks where this happened:

image

This needs to be researched in the next meeting, because they actually have values these series:

image

So we can't just delete these data, we need to go one by one of these 5 stocks to check if this information is important.

@cmspinto
Copy link
Collaborator

For these two stocks there was name of the columns but no values in the custom columns: 10284, 10309

So these two were updated but it's possible to revert the changes.

@Milldaz
Copy link
Collaborator

Milldaz commented Nov 27, 2024

We were talking about CustomRefPointName (the reference points), not CustomName (the time series).

@cmspinto
Copy link
Collaborator

cmspinto commented Nov 27, 2024

I checked both ;), but the issue is also about the data values, this is the text:

image

About the customRefName we need to check it in the next meeting:

image

@lucalamoni
Copy link
Author

It might be that I made an error in my description and as @Milldaz said, this issue is localised to the CustomRefPointNames in the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: (NEW) Wishlist
Development

No branches or pull requests

3 participants