Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAG to dos #238

Open
2 of 6 tasks
LApetre opened this issue Apr 28, 2023 · 0 comments
Open
2 of 6 tasks

SAG to dos #238

LApetre opened this issue Apr 28, 2023 · 0 comments
Assignees
Labels

Comments

@LApetre
Copy link

LApetre commented Apr 28, 2023

  • Sometimes an MSY reference point needs to be added in the custom reference points (e.g. Fmsy proxy). Ideally the type of line used should be the same as that used for Fmsy i.e. light blue line (e.g. if the name of the custom reference point has the letters 'msy' in it, make it blue - I don't think there is ever more than two reference points with 'msy' in the names on the same plot so there shouldn't be a duplication of styles). Longer term I think we need to add F_{MSY proxy} as a standard reference point. e.g. Fishing Pressure plot in https://standardgraphs.ices.dk/manage/ViewGraphsAndTables.aspx?key=18198

  • In this stock I have tried to add Fmgt in the legend of the F plot:
    https://standardgraphs.ices.dk/manage/ViewGraphsAndTables.aspx?key=18044
    I called it F_{mgt}, but in the legend it comes out as F_{mgt}
    If I make the first letter a capital it works fine i.e. F_{Mgt} gives FMgt
    Any idea why I can’t get it to say Fmgt?

  • The colours used for stacked bar plots in custom graphs aren't really different enough. It makes it difficult to read the plot. We need to have clearly different colours for each consecutive series I think (e.g. we can have those different shades of green, but should have some different blue or orange between them at least). e.g. see the custom plot (Landings by Area) here: https://standardgraphs.ices.dk/manage/ViewGraphsAndTables.aspx?key=18098

  • In the Catch plot in SAG there is an option “Present catches (ICES landings, discards, IBC and unalocated, Custom field)”. If you have just landings and discards (the most common form), landings are dark blue and discards are light blue. It would be good if these too (and IBC) were always the same colour. However, when you add a custom field, that field gets the light blue colour in the plot (see below). Could you fix it to always have the same colours for landings, discards, IBC and unallocated (the standard fields), and then a 5th colour for the custom one? e.g. In this plot (https://standardgraphs.ices.dk/manage/ViewGraphsAndTables.aspx?key=17901) it would be better if discards was light blue, and the ‘model estimated discards’ was green (or something else).
    Another example: https://standardgraphs.ices.dk/manage/ViewGraphsAndTables.aspx?key=17878

  • Fix .xml download. The xml file that is downloaded can only be uploaded again if the 'Chart Settings' section is removed. Either need to fix the chart settings or not export the chart settings in the .xml

  • Fix how "MSY Btrigger" is displayed in the legends (SSB graph and historic graph). Should be MSY B_{trigger} i.e. no space between "MSY B" and "trigger", "trigger" in subscript

  • [ ]

@LApetre LApetre self-assigned this Apr 28, 2023
@LApetre LApetre added the SAG label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants