Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds implementation of iterable pytorch dataset for use with tfrecords #281

Closed
wants to merge 1 commit into from
Closed

Adds implementation of iterable pytorch dataset for use with tfrecords #281

wants to merge 1 commit into from

Conversation

ampersandmcd
Copy link

Addresses #280, perhaps imperfectly! Would appreciate a few additional eyes and tests on this.

@ampersandmcd ampersandmcd linked an issue Jun 24, 2024 that may be closed by this pull request
Use preprocessed and cached tfrecord datasets with PyTorch #280
Open
@bnubald bnubald self-requested a review June 24, 2024 12:34
@bnubald
Copy link
Collaborator

bnubald commented Jul 29, 2024

Thanks for submitting this PR Andrew!

As discussed in meeting, will opt for an alternate approach since torchdata seems to be in an inactive state, and with this approach, loading from tfrecords cached files seems to take quite a bit longer than just reading directly from the source netCDF files, interesting topic to consider again when look into scaling with pytorch based dataloaders.

@bnubald bnubald closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnubald bnubald Awaiting requested review from bnubald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use preprocessed and cached tfrecord datasets with PyTorch
2 participants
@ampersandmcd @bnubald