Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #235 defensive generate workers #267

Merged
merged 2 commits into from
May 29, 2024
Merged

Fixes #235 defensive generate workers #267

merged 2 commits into from
May 29, 2024

Conversation

bnubald
Copy link
Collaborator

@bnubald bnubald commented May 29, 2024

Resolves #235

Uses .get to set defaults for generate_workers to cover previous versions where this was not specfied in the dataset_config.{name}.config file.

@bnubald bnubald added the defensive Attempting to cover different error scenarios label May 29, 2024
@bnubald bnubald added this to the v0.2.9 milestone May 29, 2024
@bnubald bnubald requested a review from JimCircadian May 29, 2024 10:58
@bnubald bnubald self-assigned this May 29, 2024
@bnubald bnubald linked an issue May 29, 2024 that may be closed by this pull request
generate_workers missing on icenet_train #235
Open
@bnubald bnubald merged commit afcad65 into icenet-ai:v0.2.9_dev May 29, 2024
@bnubald bnubald deleted the 235_defensive_generate_workers branch May 29, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimCircadian JimCircadian JimCircadian approved these changes

Assignees

@bnubald bnubald

Labels
defensive Attempting to cover different error scenarios
Projects
None yet
Milestone
v0.2.9
Development

Successfully merging this pull request may close these issues.

generate_workers missing on icenet_train
2 participants
@bnubald @JimCircadian