Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML escaping with .to_json in views and partials #1

Open
josephinehall opened this issue Jul 13, 2015 · 0 comments
Open

HTML escaping with .to_json in views and partials #1

josephinehall opened this issue Jul 13, 2015 · 0 comments

Comments

@josephinehall
Copy link
Contributor

For some reason using .to_json in a view or partial is resulting in some incorrect HTML output.

At the moment we're required to manually escape the results of .to_json, for example as part of viewloader js components:

data-view-welcome=Temple::Utils.escape_html({dismissSelector: ".welcome__dismiss", zoomSelector: ".zoom", storyMarkersSelector: ".story-marker-group"}.to_json)

We've experimented with using the following configuration, but without much luck so far:
# Configure Slim
Slim::Engine.options[:use_html_safe] = true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephinehall