Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is broken due to dependency versions between skrifa & read-fonts #2646

Open
4 tasks done
stonkie opened this issue Oct 22, 2024 · 0 comments
Open
4 tasks done
Labels
bug Something isn't working

Comments

@stonkie
Copy link

stonkie commented Oct 22, 2024

Is your issue REALLY a bug?

  • My issue is indeed a bug!
  • I am not crazy! I will not fill out this form just to ask a question or request a feature. Pinky promise.

Is there an existing issue for this?

  • I have searched the existing issues.

Is this issue related to iced?

  • My hardware is compatible and my graphics drivers are up-to-date.

What happened?

I cloned the examples fresh, tried to build and it wouldn't build due to an breaking change in read-fonts, incompatible with the currently pinned version of skrifa.

cargo update on my apps using iced also broke my builds.

The error was as follows :

error[E0599]: no method named `get_compatibility_id` found for reference `&TableRef<'_, PatchMapFormat2Marker>` in the current scope
   --> C:\Users\kcoulombe\.cargo\registry\src\index.crates.io-6f17d22bba15001f\skrifa-0.22.3\src\patchmap.rs:278:25
    |
278 |     let compat_id = map.get_compatibility_id();
    |                         ^^^^^^^^^^^^^^^^^^^^
    |
help: there is a method `compatibility_id` with a similar name
    |
278 |     let compat_id = map.compatibility_id();
    |                         ~~~~~~~~~~~~~~~~

This was needed to fix it temporarily, reverting read-fonts to 0.22.3 (instead of 0.22.4) :

image

[[package]]
name = "read-fonts"
version = "0.22.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "fb94d9ac780fdcf9b6b252253f7d8f221379b84bd3573131139b383df69f85e1"
dependencies = [
 "bytemuck",
 "font-types",
]

I'm a Rust noob, but I suspect this comes from a downstream dependency and will likely get fixed on its own, but at least the next guy hitting this will hopefully find this and waste less time than I did. ;)

Note : It would be nice to commit the cargo.lock file and use a bot to upgrade everything, although I get it's another maintenance burden...

What is the expected behavior?

clone the repo, run the examples, no build errors

Version

master

Operating System

Windows

Do you have any log output?

No response

@stonkie stonkie added the bug Something isn't working label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant