Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor prepare_frame_packet #260

Open
tianluyuan opened this issue Jan 8, 2024 · 2 comments
Open

Refactor prepare_frame_packet #260

tianluyuan opened this issue Jan 8, 2024 · 2 comments
Labels
tech debt cleanup We need to do this to avoid tech debt

Comments

@tianluyuan
Copy link
Contributor

The function prepare_frame_packet in extract_json_message.py consists of many moving parts and changes to state. One example, mentioned in #244 is the call to prepare_frames(frame_packet, ...) which modifies and returns an updated list of frames. We should try to simplify / clean up this function.
@tianluyuan tianluyuan added the tech debt cleanup We need to do this to avoid tech debt label Jan 8, 2024
@tianluyuan tianluyuan mentioned this issue Jan 8, 2024
Merged
@ric-evans
Copy link
Member

link: #244 (comment)

@mlincett
Copy link
Collaborator

mlincett commented Jan 8, 2024

I had outlined some ideas about this in #149 , but then abandoned that path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt cleanup We need to do this to avoid tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mlincett @tianluyuan @ric-evans