Deprecate some arguments in start_scan
and refactor fallback seed
#230
Labels
tech debt cleanup
We need to do this to avoid tech debt
The following arguments of
start_scan
:input_time_name: str
input_pos_name: str
output_particle_name: str
define the starting seed (
fallback_*
) and the current seedoutput_particle_name
.These arguments are never used and they always correspond to default values.
What reco modules do now is write the starting seed to the default value of
input_(pos|time)_name
(server-side) which iscfg.INPUT_(POS|TIME)_NAME
and read the current seed from the default value ofoutput_particle_name
(client-side) which iscfg.OUTPUT_PARTICLE_NAME
.In other words, there is no benefit in defining any of this in
start_scan
. The reco module could provide a name for the starting seed (optionally, more than one) whileoutput_particle_name
is purely conventional.The text was updated successfully, but these errors were encountered: