Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OUTPUT_PARTICLE_NAME to be reconstruction-neutral #164

Open
mlincett opened this issue Mar 31, 2023 · 1 comment
Open

Change OUTPUT_PARTICLE_NAME to be reconstruction-neutral #164

mlincett opened this issue Mar 31, 2023 · 1 comment
Labels
tech debt cleanup We need to do this to avoid tech debt

Comments

@mlincett
Copy link
Collaborator

Currently config.py specifies:

OUTPUT_PARTICLE_NAME: Final = "MillipedeSeedParticle"

and I believe the key should be made neutral w.r.t. the reconstruction algorithm (i.e. "RecoSeedParticle"), in order to improve readability of the code (although functionally speaking this is irrelevant).

This change would be trivial, if it wasn't for the fact that the key is hardcoded in some test data that would need to be updated, namely pframe pickles at: https://github.com/icecube/skymap_scanner/tree/main/tests/data/reco_pixel_pkls

Note that I would also change OUTPUT_PARTICLE_NAME to something more meaningful such as SEED_PARTICLE_NAME. This is an "output" only from the point of view of the server, but for the client it's an input.

@ric-evans
Copy link
Member

@mlincett can this be closed?

@ric-evans ric-evans added the tech debt cleanup We need to do this to avoid tech debt label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt cleanup We need to do this to avoid tech debt
Projects
None yet
Development

No branches or pull requests

2 participants