You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make sure that it does not return negative PDF values. It could be done by flooring them to 0 and renormalizing the PDF? Zero gradient could create issues
The text was updated successfully, but these errors were encountered:
Special care has to be taken when rounding floating point numbers. With a regular grid it is easier to make sure that all values are rounded to the specified decimal precision. I guess this can be achieved also with an irregular grid. But I would recommend to add excessive unit test coverage to ensure correct behavior.
If the rounding of a value is not consistent to fall on exact grid point values, the interpolation / PDF value lookup will fail, most probably for only a few values.
The
ParameterGrid
class could be merged with theIrregularParameterGrid
, as there is no fundamental reason why it has to have a regular grid.TODO:
Parabola1DGridManifoldInterpolationMethod
interpolation to support an irregular grid:skyllh/skyllh/core/interpolate.py
Lines 672 to 673 in 6c3e66f
The text was updated successfully, but these errors were encountered: