instant slashing of all balance in case of kycQuizResetAt passed #107
Conversation
miner/mining.go
Outdated
| updatedUser.SlashingRateForTMinus1 = usr.BalanceForTMinus1 / elapsedTimeFraction | ||
| } | ||
| } | ||
| func (updatedUser *user) restoreInstantSlashing(usr *user, t0Ref, tMinus1Ref *referral, unAppliedSoloPending, elapsedTimeFraction float64) { |
There was a problem hiding this comment.
Not sure that this function is needed at all as if:
- user has mined minimal balance after burning out of balances, he don't need in slashing rates for the next iteration.
- user in slashing, he still will have 0 in balances.
miner/mining.go
Outdated
| } | ||
|
|
||
| if needSlashDueToQuizReset { | ||
| updatedUser.applyInstantSlashing(usr, t0Ref, tMinus1Ref, unAppliedSoloPending, elapsedTimeFraction) |
There was a problem hiding this comment.
Will not lines 111, 118 affect on slashingRatesForT0 and TMinus1 that they will not be accepted at 165-166?
model/model.go
Outdated
| @@ -408,6 +413,20 @@ func (kyc *KYCState) DelayPassedSinceLastKYCStepAttempt(kycStep users.KYCStep, d | |||
| return kyc.KYCStepAttempted(kycStep) && time.Now().Sub(*(*kyc.KYCStepsLastUpdatedAt)[kycStep-1].Time) >= duration | |||
| } | |||
|
|
|||
| func (kyc *KYCState) WasQuizReset(now *time.Time) bool { | |||
There was a problem hiding this comment.
now is not a good name; try past
ice-cronus
force-pushed
the
feature/quiz_reset_balances
branch
from
dd7c747 to
fdd092f
Compare
miner/resurrection.go
Outdated
|
|
||
| usr.BalanceSolo += usr.SlashingRateSolo * resurrectDelta | ||
| usr.BalanceT0 += usr.SlashingRateT0 * resurrectDelta | ||
| amountSolo := usr.SlashingRateSolo * resurrectDelta |
miner/mining.go
Outdated
| @@ -14,14 +14,19 @@ func mine(baseMiningRate float64, now *time.Time, usr *user, t0Ref, tMinus1Ref * | |||
| clonedUser1 := *usr | |||
| updatedUser = &clonedUser1 | |||
| pendingResurrectionForTMinus1, pendingResurrectionForT0 := resurrect(now, updatedUser, t0Ref, tMinus1Ref) | |||
| wasResurrected := !updatedUser.ResurrectSoloUsedAt.IsNil() && updatedUser.ResurrectSoloUsedAt.Equal(*now.Time) | |||
There was a problem hiding this comment.
what about if t0/t-1 resurrected?
miner/mining.go
Outdated
|
|
||
| needInstantSlashing := usr.WasQuizReset(updatedUser.BalanceLastUpdatedAt) | ||
| if wasResurrected && needInstantSlashing { | ||
| updatedUser.ResurrectSoloUsedAt = nil |
There was a problem hiding this comment.
you should consume the resurrection, but it shouldn't resurrect the coins u lost forever
There was a problem hiding this comment.
But it seems situation when we have to resurrect part of the coins are impossible, in instant slashing we slash all the balance, and slashing stops, nothing to be resuttected if instant slashing occured (so that reset date does not affect to resurrectedDelta in anyway it seems)
There was a problem hiding this comment.
Yea but u dont consume the resurrection
miner/mining.go
Outdated
|
|
||
| needInstantSlashing := usr.WasQuizReset(updatedUser.BalanceLastUpdatedAt) | ||
| if wasResurrected && needInstantSlashing { | ||
| updatedUser.ResurrectSoloUsedAt = nil |
No description provided.