Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple dependencies of ACIM #553

Open
Petingo opened this issue Nov 30, 2024 · 0 comments
Open

Decouple dependencies of ACIM #553

Petingo opened this issue Nov 30, 2024 · 0 comments
Assignees
Labels
refactor non-breaking codebase improvement

Comments

@Petingo
Copy link
Collaborator

Petingo commented Nov 30, 2024

  1. Dependency of Config.h:
    Acquiring the value in config outside and passing it to the constructor might be better.

    m_Scale = AIAC::Config::Get<float>(AIAC::Config::SEC_AIAC, AIAC::Config::SCALE_FACTOR, 1.0f);

  2. Dependency of other layers:
    This layer stuff should not be handled in this class. The upper layer that calls this function should take care of it. Perhaps using the event system.

    AIAC_APP.GetLayer<LayerModel>()->GetACInfoModel().GetDoc().child("acim").child("timber").child("current").last_child().set_value(m_ID.c_str());

@Petingo Petingo added the refactor non-breaking codebase improvement label Nov 30, 2024
@Petingo Petingo self-assigned this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor non-breaking codebase improvement
Projects
None yet
Development

No branches or pull requests

1 participant