Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and improvement of GenerateInt32Stub and related FloatingPointer Helpers #59

Open
pengwuibm opened this issue Jul 13, 2013 · 2 comments

Comments

@pengwuibm
Copy link
Contributor

Use this issue to track all code refactoring and improvement for GenerateInt32Stub and related floating point helpers. Observed inefficiency include:

  • MOD handling that requires loading double into 2 integer GPRs and then call CallCCodeForDoubleOperation that constructs double out of 2 integer
  • The special MOD handling complicates the implementation of LoadNumberAsInt32Double, LoadSmi, LoadNumbers to deal w/ destination of kFPRegisters and kCoreRegisters differently
  • Current floating to int conversion uses unoptimized sequence, should use code sequences generated for pwr4 and later architectures
  • Unclear why it is necessary to do int32 operation in floating-point (which requires conversion back and forth) on PPC
@ghost ghost assigned pengwuibm Jul 13, 2013
@pengwuibm
Copy link
Contributor Author

Simplify the interface for ConvertIntToDouble: 2a7db58

@pengwuibm
Copy link
Contributor Author

Removed ConvertDoubleToInt and ConvertDoubleToUnsignedInt to use EmitECMATruncate instead 746de9d, which handles corner cases correctly and use more efficient pwr5 instruction sequence for double to int conversion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant