-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erroneous EBCDIC tables in zipl/boot/ebcdic_conv.c #125
Comments
When Wikipedia is correct, the tables should not be exactly the same. In https://en.wikipedia.org/wiki/Code_page_37 is stated: |
Yes, there should definitely be a difference in the tables, you can see it in the Linux kernel sources, too (arch/s390/kernel/ebcdic.c). See my comment here for a suggestion how to fix it: |
zipl/boot/ebcdic_conv.c contains two tables for converting EBCDIC to ASCII, ebcdic_037 and ebcdic_500. However, if you compare the two tables line by line, you can see that they are exactly the same! So this is either a waste of precious bytes, or one of the tables is just wrong.
Comparing the tables with the ones in the Linux kernel (arch/s390/kernel/ebcdic.c), it seems to me like ebcdic_500 is wrong and needs fixing?
The text was updated successfully, but these errors were encountered: