From b495b54d27d3b258f8a585d2f665aaf228c019cf Mon Sep 17 00:00:00 2001 From: "philip.cline" Date: Thu, 5 Oct 2023 15:51:58 -0400 Subject: [PATCH 1/8] feat(SnapshotModal): add option to export patterns in editor --- i18n/english.yml | 2 ++ i18n/german.yml | 2 ++ i18n/polish.yml | 2 ++ lib/editor/actions/snapshots.js | 5 ++--- lib/editor/components/CreateSnapshotModal.js | 23 ++++++++++++++++++-- 5 files changed, 29 insertions(+), 5 deletions(-) diff --git a/i18n/english.yml b/i18n/english.yml index bed509560..cf0580bcf 100644 --- a/i18n/english.yml +++ b/i18n/english.yml @@ -87,6 +87,8 @@ components: placeholder: Additional information (optional) publishNewVersion: label: Publish snapshot as new feed version + publishProprietaryFiles: + label: Publish new feed version with proprietary (extra) datatools files. confirmPublishWithUnapproved: label: Confirm publish with unapproved routes unapprovedRoutesHeader: "The following routes are not approved" diff --git a/i18n/german.yml b/i18n/german.yml index c6cadaf2d..75c213b6c 100644 --- a/i18n/german.yml +++ b/i18n/german.yml @@ -80,6 +80,8 @@ components: placeholder: Name des Schnappschusses (erforderlich) publishNewVersion: label: Veröffentliche Schnappschuss als neue Feed-Version + publishProprietaryFiles: + label: Publish new feed version with proprietary (extra) datatools files. missingNameAlert: Gültiger Schnappschuss-Name erforderlich! ok: OK title: Neuen Schnappschuss erstellen diff --git a/i18n/polish.yml b/i18n/polish.yml index 23e84abcb..ca416aad8 100644 --- a/i18n/polish.yml +++ b/i18n/polish.yml @@ -79,6 +79,8 @@ components: placeholder: Nazwa migawki (wymagana) publishNewVersion: label: Publikuj migawkę jako nowa wersja pliku + publishProprietaryFiles: + label: Publish new feed version with proprietary (extra) datatools files. missingNameAlert: Migawce należy nadać prawidłową nazwę! ok: OK title: Utwórz nową migawkę diff --git a/lib/editor/actions/snapshots.js b/lib/editor/actions/snapshots.js index 70e695027..b7c45e7f0 100644 --- a/lib/editor/actions/snapshots.js +++ b/lib/editor/actions/snapshots.js @@ -5,7 +5,6 @@ import {createAction, type ActionType} from 'redux-actions' import {secureFetch} from '../../common/actions' import {getConfigProperty} from '../../common/util/config' import {handleJobResponse} from '../../manager/actions/status' - import type {Feed, Snapshot} from '../../types' import type {dispatchFn, getStateFn} from '../../types/reducers' @@ -87,9 +86,9 @@ export function downloadSnapshotViaCredentials (snapshot: Snapshot, isPublic: bo /** * Create a new snapshot from the data currently present in the editor buffer. */ -export function createSnapshot (feedSource: Feed, name: string, comment?: ?string, publishNewVersion?: boolean) { +export function createSnapshot (feedSource: Feed, name: string, comment?: ?string, publishNewVersion?: boolean, publishProprietaryFiles?: boolean) { return function (dispatch: dispatchFn, getState: getStateFn) { - const url = `/api/editor/secure/snapshot?feedId=${feedSource.id}${publishNewVersion ? '&publishNewVersion=true' : ''}` + const url = `/api/editor/secure/snapshot?feedId=${feedSource.id}${publishNewVersion ? '&publishNewVersion=true' : ''}${publishProprietaryFiles ? '&publishProprietaryFiles=true' : ''}` const snapshot = { feedId: feedSource.id, name, diff --git a/lib/editor/components/CreateSnapshotModal.js b/lib/editor/components/CreateSnapshotModal.js index 2c74f2d25..3c223784e 100644 --- a/lib/editor/components/CreateSnapshotModal.js +++ b/lib/editor/components/CreateSnapshotModal.js @@ -34,6 +34,7 @@ type State = { loading: boolean, name: ?string, publishNewVersion: boolean, + publishProprietaryFiles: boolean, showModal: boolean, } @@ -42,6 +43,7 @@ function getDefaultState () { comment: null, name: formatTimestamp(), publishNewVersion: false, + publishProprietaryFiles: false, confirmPublishWithUnapproved: false, showModal: false, loading: false @@ -54,6 +56,12 @@ class CreateSnapshotModal extends Component { messages = getComponentMessages('CreateSnapshotModal') _onTogglePublish = (e: SyntheticInputEvent) => { + // If unchecking publishNewVersion, we need to also uncheck publishProprietaryFiles + if (!e.target.checked) this.setState({publishProprietaryFiles: false}) + this.setState({[e.target.name]: e.target.checked}) + } + + _onTogglePublishProprietaryFiles = (e: SyntheticInputEvent) => { this.setState({[e.target.name]: e.target.checked}) } @@ -91,9 +99,9 @@ class CreateSnapshotModal extends Component { ok = () => { const {createSnapshot, feedSource} = this.props - const {comment, name, publishNewVersion} = this.state + const {comment, name, publishNewVersion, publishProprietaryFiles} = this.state if (!name) return window.alert(this.messages('missingNameAlert')) - createSnapshot(feedSource, name, comment, publishNewVersion) + createSnapshot(feedSource, name, comment, publishNewVersion, publishProprietaryFiles) this.close() } @@ -105,6 +113,7 @@ class CreateSnapshotModal extends Component { loading, name, publishNewVersion, + publishProprietaryFiles, showModal } = this.state const {routes} = this.props @@ -149,6 +158,16 @@ class CreateSnapshotModal extends Component { onChange={this._onTogglePublish}> {this.messages('fields.publishNewVersion.label')} + {publishNewVersion && + + {this.messages('fields.publishProprietaryFiles.label')} + + } {loading && } {unapprovedRoutes.length > 0 && From fcd325308b6e07c7c32e557ca6ea125a7758c474 Mon Sep 17 00:00:00 2001 From: "philip.cline" Date: Fri, 6 Oct 2023 15:46:22 -0400 Subject: [PATCH 2/8] refactor(CreateSnapshotModal): add help text --- i18n/english.yml | 1 + i18n/german.yml | 1 + i18n/polish.yml | 1 + lib/editor/components/CreateSnapshotModal.js | 26 ++++++++++++-------- 4 files changed, 19 insertions(+), 10 deletions(-) diff --git a/i18n/english.yml b/i18n/english.yml index cf0580bcf..c9ac264d3 100644 --- a/i18n/english.yml +++ b/i18n/english.yml @@ -88,6 +88,7 @@ components: publishNewVersion: label: Publish snapshot as new feed version publishProprietaryFiles: + helpText: Proprietary files allow you to maintain Datatools certain proprietary features across feed version, e.g. Pattern names. label: Publish new feed version with proprietary (extra) datatools files. confirmPublishWithUnapproved: label: Confirm publish with unapproved routes diff --git a/i18n/german.yml b/i18n/german.yml index 75c213b6c..7249dc09c 100644 --- a/i18n/german.yml +++ b/i18n/german.yml @@ -81,6 +81,7 @@ components: publishNewVersion: label: Veröffentliche Schnappschuss als neue Feed-Version publishProprietaryFiles: + helpText: Proprietary files allow you to maintain Datatools certain proprietary features across feed version, e.g. Pattern names. label: Publish new feed version with proprietary (extra) datatools files. missingNameAlert: Gültiger Schnappschuss-Name erforderlich! ok: OK diff --git a/i18n/polish.yml b/i18n/polish.yml index ca416aad8..6a0e197a9 100644 --- a/i18n/polish.yml +++ b/i18n/polish.yml @@ -80,6 +80,7 @@ components: publishNewVersion: label: Publikuj migawkę jako nowa wersja pliku publishProprietaryFiles: + helpText: Proprietary files allow you to maintain Datatools certain proprietary features across feed version, e.g. Pattern names. label: Publish new feed version with proprietary (extra) datatools files. missingNameAlert: Migawce należy nadać prawidłową nazwę! ok: OK diff --git a/lib/editor/components/CreateSnapshotModal.js b/lib/editor/components/CreateSnapshotModal.js index 3c223784e..9fa9688fc 100644 --- a/lib/editor/components/CreateSnapshotModal.js +++ b/lib/editor/components/CreateSnapshotModal.js @@ -8,7 +8,9 @@ import { ControlLabel, FormGroup, FormControl, - Modal + Modal, + OverlayTrigger, + Tooltip } from 'react-bootstrap' import {connect} from 'react-redux' @@ -151,7 +153,7 @@ class CreateSnapshotModal extends Component { placeholder={this.messages('fields.comment.placeholder')} /> - + { {this.messages('fields.publishNewVersion.label')} {publishNewVersion && - - {this.messages('fields.publishProprietaryFiles.label')} - + {this.messages('fields.publishProprietaryFiles.helpText')}}> + + + {this.messages('fields.publishProprietaryFiles.label')} + + + } {loading && } From 3a600e37c733c1f031bf717874fea95e92b4c324 Mon Sep 17 00:00:00 2001 From: "philip.cline" Date: Mon, 6 Nov 2023 16:59:22 -0500 Subject: [PATCH 3/8] refactor(ExportPatternsModal): allow pattern export for snapshots --- i18n/english.yml | 8 ++- i18n/german.yml | 2 +- i18n/polish.yml | 2 +- lib/common/components/ExportPatternsModal.js | 62 +++++++++++++++++++ .../components/EditorFeedSourcePanel.js | 18 ++++-- lib/manager/actions/versions.js | 5 +- 6 files changed, 87 insertions(+), 10 deletions(-) create mode 100644 lib/common/components/ExportPatternsModal.js diff --git a/i18n/english.yml b/i18n/english.yml index c9ac264d3..0cb0e5cce 100644 --- a/i18n/english.yml +++ b/i18n/english.yml @@ -88,7 +88,7 @@ components: publishNewVersion: label: Publish snapshot as new feed version publishProprietaryFiles: - helpText: Proprietary files allow you to maintain Datatools certain proprietary features across feed version, e.g. Pattern names. + helpText: Proprietary files allow you to maintain certain proprietary Datatools features across feed version, e.g. Pattern names. label: Publish new feed version with proprietary (extra) datatools files. confirmPublishWithUnapproved: label: Confirm publish with unapproved routes @@ -291,6 +291,7 @@ components: load: Load for Editing loadLatest: Load latest for editing name: Name + noOtherSnapshots: No other snapshots noSnapshotsExist: No snapshots currently exist for this feed. Snapshots can be created within the Editor. Click "Edit Feed" to enter editing mode. noVersions: (No Versions) noVersionsExist: No versions exist for this feed source. @@ -337,6 +338,11 @@ components: deleteRange: Delete range ExceptionValidationErrorsList: andOtherErrors: ...and %errors% other errors + ExportPatternsModal: + exportPatterns: Publish version with proprietary patterns? + exportPatternsBody: A lot of text + yes: Yes + no: No FeedFetchFrequency: DAYS: days fetchFeedEvery: Fetch feed every diff --git a/i18n/german.yml b/i18n/german.yml index 7249dc09c..380bd0488 100644 --- a/i18n/german.yml +++ b/i18n/german.yml @@ -81,7 +81,7 @@ components: publishNewVersion: label: Veröffentliche Schnappschuss als neue Feed-Version publishProprietaryFiles: - helpText: Proprietary files allow you to maintain Datatools certain proprietary features across feed version, e.g. Pattern names. + helpText: Proprietary files allow you to maintain certain proprietary Datatools features across feed version, e.g. Pattern names. label: Publish new feed version with proprietary (extra) datatools files. missingNameAlert: Gültiger Schnappschuss-Name erforderlich! ok: OK diff --git a/i18n/polish.yml b/i18n/polish.yml index 6a0e197a9..93e0c54c1 100644 --- a/i18n/polish.yml +++ b/i18n/polish.yml @@ -80,7 +80,7 @@ components: publishNewVersion: label: Publikuj migawkę jako nowa wersja pliku publishProprietaryFiles: - helpText: Proprietary files allow you to maintain Datatools certain proprietary features across feed version, e.g. Pattern names. + helpText: Proprietary files allow you to maintain certain proprietary Datatools features across feed version, e.g. Pattern names. label: Publish new feed version with proprietary (extra) datatools files. missingNameAlert: Migawce należy nadać prawidłową nazwę! ok: OK diff --git a/lib/common/components/ExportPatternsModal.js b/lib/common/components/ExportPatternsModal.js new file mode 100644 index 000000000..c3ca2038d --- /dev/null +++ b/lib/common/components/ExportPatternsModal.js @@ -0,0 +1,62 @@ +// @flow + +import React from 'react' +import { Modal, Button } from 'react-bootstrap' + +import {getComponentMessages} from '../../common/util/config' +import * as versionActions from '../../manager/actions/versions' +import type { Feed, Snapshot } from '../../types' +import type { ItemProps } from '../../editor/components/EditorFeedSourcePanel' + +type Props = { + createFeedVersionFromSnapshot: typeof versionActions.createFeedVersionFromSnapshot, + feedSource: Feed, +} + +type State = { + showModal: boolean, + snapshot: ?Snapshot +} + +export default class ExportPatternsModal extends React.Component { + messages = getComponentMessages('ExportPatternsModal') + + state = { + showModal: false, + snapshot: null + } + + publish (publishProprietaryFiles: boolean) { + const { createFeedVersionFromSnapshot, feedSource } = this.props + this.state.snapshot && createFeedVersionFromSnapshot(feedSource, this.state.snapshot.id, publishProprietaryFiles) + this.close() + } + + close () { + this.setState({showModal: false}) + } + + // Open is called by the SnapshotItem class + open (props: ItemProps) { + this.setState({showModal: true, snapshot: props.snapshot}) + } + + render () { + const {Body, Title} = Modal + const buttonStyle = {marginLeft: '10px', width: '50px'} + + return ( + + + {this.messages('exportPatterns')} + + + + + ) + } +} diff --git a/lib/editor/components/EditorFeedSourcePanel.js b/lib/editor/components/EditorFeedSourcePanel.js index f1425a6cf..21366f104 100644 --- a/lib/editor/components/EditorFeedSourcePanel.js +++ b/lib/editor/components/EditorFeedSourcePanel.js @@ -8,6 +8,7 @@ import moment from 'moment' import * as snapshotActions from '../actions/snapshots.js' import ConfirmModal from '../../common/components/ConfirmModal' +import ExportPatternsModal from '../../common/components/ExportPatternsModal.js' import {getComponentMessages, getConfigProperty} from '../../common/util/config' import CreateSnapshotModal from '../../editor/components/CreateSnapshotModal' import * as versionActions from '../../manager/actions/versions' @@ -63,6 +64,11 @@ export default class EditorFeedSourcePanel extends Component { ref='snapshotModal' /> + {feedSource.editorSnapshots && feedSource.editorSnapshots.length ?
@@ -73,13 +79,13 @@ export default class EditorFeedSourcePanel extends Component { {snapshots.length === 0 - ? No other snapshots + ? {this.messages('noOtherSnapshots')} : snapshots.map(s => { return ( ) @@ -122,7 +128,7 @@ export default class EditorFeedSourcePanel extends Component { } } -type ItemProps = { +export type ItemProps = { createFeedVersionFromSnapshot: typeof versionActions.createFeedVersionFromSnapshot, deleteSnapshot: typeof snapshotActions.deleteSnapshot, disabled: boolean, @@ -142,8 +148,10 @@ class SnapshotItem extends Component { } _onClickExport = () => { - const {createFeedVersionFromSnapshot, feedSource, snapshot} = this.props - createFeedVersionFromSnapshot(feedSource, snapshot.id) + this.props.modal.open({ + body: this.messages('exportPatternsBody'), + snapshot: this.props.snapshot + }) } _onDeleteSnapshot = () => { diff --git a/lib/manager/actions/versions.js b/lib/manager/actions/versions.js index a89fdb7df..fe0bc9d35 100644 --- a/lib/manager/actions/versions.js +++ b/lib/manager/actions/versions.js @@ -543,10 +543,11 @@ export function downloadFeedViaToken ( */ export function createFeedVersionFromSnapshot ( feedSource: Feed, - snapshotId: string + snapshotId: string, + publishProprietaryFiles: boolean ) { return function (dispatch: dispatchFn, getState: getStateFn) { - const url = `${SECURE_API_PREFIX}feedversion/fromsnapshot?feedSourceId=${feedSource.id}&snapshotId=${snapshotId}` + const url = `${SECURE_API_PREFIX}feedversion/fromsnapshot?feedSourceId=${feedSource.id}&snapshotId=${snapshotId}&publishProprietaryFiles=${publishProprietaryFiles.toString()}` return dispatch(secureFetch(url, 'post')) .then(res => dispatch(handleJobResponse(res, 'Error downloading snapshot'))) } From ce2a8035db8b140f18988e8efdeea1f6d1696214 Mon Sep 17 00:00:00 2001 From: "philip.cline" Date: Mon, 6 Nov 2023 17:08:00 -0500 Subject: [PATCH 4/8] refactor(i18n): update lang files --- i18n/english.yml | 2 +- i18n/german.yml | 6 ++++++ i18n/polish.yml | 6 ++++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/i18n/english.yml b/i18n/english.yml index 0cb0e5cce..ca64fcf59 100644 --- a/i18n/english.yml +++ b/i18n/english.yml @@ -341,8 +341,8 @@ components: ExportPatternsModal: exportPatterns: Publish version with proprietary patterns? exportPatternsBody: A lot of text - yes: Yes no: No + yes: Yes FeedFetchFrequency: DAYS: days fetchFeedEvery: Fetch feed every diff --git a/i18n/german.yml b/i18n/german.yml index 380bd0488..a9e9244d8 100644 --- a/i18n/german.yml +++ b/i18n/german.yml @@ -298,6 +298,7 @@ components: load: Zur Bearbeitung laden loadLatest: Aktuellsten zur Bearbeitung herunterladen name: Name + noOtherSnapshots: No other snapshots noSnapshotsExist: Für diese Feed-Quelle existieren noch keine Schnappschüsse. Schnappschüsse können im Editor erstellt werden. Wählen Sie "Feed bearbeiten" um den Bearbeitungsmodus zu starten. @@ -349,6 +350,11 @@ components: deleteRange: Delete range ExceptionValidationErrorsList: andOtherErrors: ...and %errors% other errors + ExportPatternsModal: + exportPatterns: Publish version with proprietary patterns? + exportPatternsBody: A lot of text + no: No + yes: Yes FeedActionsDropdown: delete: Löschen deleteFeedSource: Feed-Quelle löschen? diff --git a/i18n/polish.yml b/i18n/polish.yml index 93e0c54c1..f79c2796a 100644 --- a/i18n/polish.yml +++ b/i18n/polish.yml @@ -296,6 +296,7 @@ components: load: Wczytaj do edycji loadLatest: Załaduj najnowszy do edycji name: Nazwa + noOtherSnapshots: No other snapshots noSnapshotsExist: Obecnie nie istnieją żadne zrzuty tego kanału. Migawki można tworzyć w Edytorze. Kliknij „Edytuj kanał”, aby przejść do trybu edycji. noVersions: (Brak wersji) @@ -344,6 +345,11 @@ components: deleteRange: Delete range ExceptionValidationErrorsList: andOtherErrors: ...and %errors% other errors + ExportPatternsModal: + exportPatterns: Publish version with proprietary patterns? + exportPatternsBody: A lot of text + no: No + yes: Yes FeedActionsDropdown: delete: Delete deleteFeedSource: Delete Feed Source? From 6516447ec590d54b51f156015d0c773bb099cf9c Mon Sep 17 00:00:00 2001 From: "philip.cline" Date: Mon, 6 Nov 2023 17:13:11 -0500 Subject: [PATCH 5/8] refactor(i18n): fix messages --- i18n/english.yml | 1 - i18n/german.yml | 1 - i18n/polish.yml | 1 - lib/editor/components/EditorFeedSourcePanel.js | 5 +---- 4 files changed, 1 insertion(+), 7 deletions(-) diff --git a/i18n/english.yml b/i18n/english.yml index ca64fcf59..ba40323fc 100644 --- a/i18n/english.yml +++ b/i18n/english.yml @@ -340,7 +340,6 @@ components: andOtherErrors: ...and %errors% other errors ExportPatternsModal: exportPatterns: Publish version with proprietary patterns? - exportPatternsBody: A lot of text no: No yes: Yes FeedFetchFrequency: diff --git a/i18n/german.yml b/i18n/german.yml index a9e9244d8..d5ccbde40 100644 --- a/i18n/german.yml +++ b/i18n/german.yml @@ -352,7 +352,6 @@ components: andOtherErrors: ...and %errors% other errors ExportPatternsModal: exportPatterns: Publish version with proprietary patterns? - exportPatternsBody: A lot of text no: No yes: Yes FeedActionsDropdown: diff --git a/i18n/polish.yml b/i18n/polish.yml index f79c2796a..db6b6939f 100644 --- a/i18n/polish.yml +++ b/i18n/polish.yml @@ -347,7 +347,6 @@ components: andOtherErrors: ...and %errors% other errors ExportPatternsModal: exportPatterns: Publish version with proprietary patterns? - exportPatternsBody: A lot of text no: No yes: Yes FeedActionsDropdown: diff --git a/lib/editor/components/EditorFeedSourcePanel.js b/lib/editor/components/EditorFeedSourcePanel.js index 21366f104..2ec08b3cd 100644 --- a/lib/editor/components/EditorFeedSourcePanel.js +++ b/lib/editor/components/EditorFeedSourcePanel.js @@ -148,10 +148,7 @@ class SnapshotItem extends Component { } _onClickExport = () => { - this.props.modal.open({ - body: this.messages('exportPatternsBody'), - snapshot: this.props.snapshot - }) + this.props.modal.open({snapshot: this.props.snapshot}) } _onDeleteSnapshot = () => { From e36a521807f100ae316ff92c8f1eb80699b6a3f6 Mon Sep 17 00:00:00 2001 From: "philip.cline" Date: Tue, 7 Nov 2023 09:39:17 -0500 Subject: [PATCH 6/8] refactor(e2e tests): account for snapshot modal --- __tests__/end-to-end.js | 4 ++++ lib/common/components/ExportPatternsModal.js | 11 +++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/__tests__/end-to-end.js b/__tests__/end-to-end.js index 1e0104e29..0f4eba539 100644 --- a/__tests__/end-to-end.js +++ b/__tests__/end-to-end.js @@ -2776,6 +2776,10 @@ describe('end-to-end', () => { // wait for snapshots tab to load and publish snapshot await waitForAndClick('[data-test-id="publish-snapshot-button"]') + + // wait for snapshot export modal and click "no" to proprietary file export + await waitForAndClick('[data-test-id="export-patterns-modal-no"]') + // wait for version to get created await waitAndClearCompletedJobs() diff --git a/lib/common/components/ExportPatternsModal.js b/lib/common/components/ExportPatternsModal.js index c3ca2038d..815606903 100644 --- a/lib/common/components/ExportPatternsModal.js +++ b/lib/common/components/ExportPatternsModal.js @@ -49,10 +49,17 @@ export default class ExportPatternsModal extends React.Component { {this.messages('exportPatterns')} - - From 0f88ac57e5493d4bf7d7808169347b6d8ea9a788 Mon Sep 17 00:00:00 2001 From: "philip.cline" Date: Wed, 8 Nov 2023 12:16:52 -0500 Subject: [PATCH 7/8] refactor(i18n): clean up language --- i18n/english.yml | 4 ++-- i18n/german.yml | 4 ++-- i18n/polish.yml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/i18n/english.yml b/i18n/english.yml index ba40323fc..5d6801f98 100644 --- a/i18n/english.yml +++ b/i18n/english.yml @@ -88,8 +88,8 @@ components: publishNewVersion: label: Publish snapshot as new feed version publishProprietaryFiles: - helpText: Proprietary files allow you to maintain certain proprietary Datatools features across feed version, e.g. Pattern names. - label: Publish new feed version with proprietary (extra) datatools files. + helpText: Proprietary files allow you to maintain certain Datatools features when re-importing, such as pattern names. + label: Publish new feed version with proprietary (extra) Datatools files. confirmPublishWithUnapproved: label: Confirm publish with unapproved routes unapprovedRoutesHeader: "The following routes are not approved" diff --git a/i18n/german.yml b/i18n/german.yml index d5ccbde40..88419ec9f 100644 --- a/i18n/german.yml +++ b/i18n/german.yml @@ -81,8 +81,8 @@ components: publishNewVersion: label: Veröffentliche Schnappschuss als neue Feed-Version publishProprietaryFiles: - helpText: Proprietary files allow you to maintain certain proprietary Datatools features across feed version, e.g. Pattern names. - label: Publish new feed version with proprietary (extra) datatools files. + helpText: Proprietary files allow you to maintain certain Datatools features when re-importing, such as pattern names. + label: Publish new feed version with proprietary (extra) Datatools files. missingNameAlert: Gültiger Schnappschuss-Name erforderlich! ok: OK title: Neuen Schnappschuss erstellen diff --git a/i18n/polish.yml b/i18n/polish.yml index db6b6939f..76b5eb4d1 100644 --- a/i18n/polish.yml +++ b/i18n/polish.yml @@ -80,8 +80,8 @@ components: publishNewVersion: label: Publikuj migawkę jako nowa wersja pliku publishProprietaryFiles: - helpText: Proprietary files allow you to maintain certain proprietary Datatools features across feed version, e.g. Pattern names. - label: Publish new feed version with proprietary (extra) datatools files. + helpText: Proprietary files allow you to maintain certain Datatools features when re-importing, such as pattern names. + label: Publish new feed version with proprietary (extra) Datatools files. missingNameAlert: Migawce należy nadać prawidłową nazwę! ok: OK title: Utwórz nową migawkę From be38792f187a651973d8ec9c75ee767d87c802cb Mon Sep 17 00:00:00 2001 From: "philip.cline" Date: Wed, 15 Nov 2023 12:18:00 -0500 Subject: [PATCH 8/8] refactor(i18n): update pattern export message --- i18n/english.yml | 2 +- i18n/german.yml | 2 +- i18n/polish.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/i18n/english.yml b/i18n/english.yml index 5d6801f98..c5ed723dc 100644 --- a/i18n/english.yml +++ b/i18n/english.yml @@ -88,7 +88,7 @@ components: publishNewVersion: label: Publish snapshot as new feed version publishProprietaryFiles: - helpText: Proprietary files allow you to maintain certain Datatools features when re-importing, such as pattern names. + helpText: Proprietary files allow you to maintain certain Datatools features, such as pattern names, when re-importing a feed. label: Publish new feed version with proprietary (extra) Datatools files. confirmPublishWithUnapproved: label: Confirm publish with unapproved routes diff --git a/i18n/german.yml b/i18n/german.yml index 88419ec9f..98a45d86b 100644 --- a/i18n/german.yml +++ b/i18n/german.yml @@ -81,7 +81,7 @@ components: publishNewVersion: label: Veröffentliche Schnappschuss als neue Feed-Version publishProprietaryFiles: - helpText: Proprietary files allow you to maintain certain Datatools features when re-importing, such as pattern names. + helpText: Proprietary files allow you to maintain certain Datatools features, such as pattern names, when re-importing a feed. label: Publish new feed version with proprietary (extra) Datatools files. missingNameAlert: Gültiger Schnappschuss-Name erforderlich! ok: OK diff --git a/i18n/polish.yml b/i18n/polish.yml index 76b5eb4d1..df7d9e94a 100644 --- a/i18n/polish.yml +++ b/i18n/polish.yml @@ -80,7 +80,7 @@ components: publishNewVersion: label: Publikuj migawkę jako nowa wersja pliku publishProprietaryFiles: - helpText: Proprietary files allow you to maintain certain Datatools features when re-importing, such as pattern names. + helpText: Proprietary files allow you to maintain certain Datatools features, such as pattern names, when re-importing a feed. label: Publish new feed version with proprietary (extra) Datatools files. missingNameAlert: Migawce należy nadać prawidłową nazwę! ok: OK