From 2f7e5a11b8740ffc38af3b6ccf3c7fdd201066a3 Mon Sep 17 00:00:00 2001 From: Dawid Parafinski Date: Wed, 20 Nov 2024 13:30:16 +0100 Subject: [PATCH] Cleanup baseline --- phpstan-baseline.neon | 369 +----------------- .../Repository/Values/Filter/Filter.php | 5 - 2 files changed, 2 insertions(+), 372 deletions(-) diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index f2cb63c381..2353c687e7 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -45,21 +45,6 @@ parameters: count: 1 path: src/bundle/Core/Command/CleanupVersionsCommand.php - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/bundle/Core/Command/CleanupVersionsCommand.php - - - - message: "#^Parameter \\#1 \\$array of function array_slice expects array, iterable\\ given\\.$#" - count: 1 - path: src/bundle/Core/Command/CleanupVersionsCommand.php - - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, iterable\\ given\\.$#" - count: 1 - path: src/bundle/Core/Command/CleanupVersionsCommand.php - - message: "#^Call to an undefined method Symfony\\\\Component\\\\Console\\\\Helper\\\\HelperInterface\\:\\:ask\\(\\)\\.$#" count: 1 @@ -5070,11 +5055,6 @@ parameters: count: 1 path: src/contracts/Persistence/Content/Location/Handler.php - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\Location\\\\Handler\\:\\:markSubtreeModified\\(\\) has no return type specified\\.$#" - count: 1 - path: src/contracts/Persistence/Content/Location/Handler.php - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\Location\\\\Handler\\:\\:setSectionForSubtree\\(\\) has no return type specified\\.$#" count: 1 @@ -5280,21 +5260,6 @@ parameters: count: 1 path: src/contracts/Persistence/Filter/LazyListIterator.php - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Handler\\:\\:beginTransaction\\(\\) has no return type specified\\.$#" - count: 1 - path: src/contracts/Persistence/Handler.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Handler\\:\\:commit\\(\\) has no return type specified\\.$#" - count: 1 - path: src/contracts/Persistence/Handler.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Handler\\:\\:rollback\\(\\) has no return type specified\\.$#" - count: 1 - path: src/contracts/Persistence/Handler.php - - message: "#^Property Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Notification\\\\CreateStruct\\:\\:\\$data type has no value type specified in iterable type array\\.$#" count: 1 @@ -6900,56 +6865,6 @@ parameters: count: 1 path: src/contracts/Repository/Values/Content/Query/Criterion/FullText.php - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\Location\\\\IsMainLocation\\:\\:createFromQueryBuilder\\(\\) has no return type specified\\.$#" - count: 1 - path: src/contracts/Repository/Values/Content/Query/Criterion/Location/IsMainLocation.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\Location\\\\IsMainLocation\\:\\:createFromQueryBuilder\\(\\) has parameter \\$operator with no type specified\\.$#" - count: 1 - path: src/contracts/Repository/Values/Content/Query/Criterion/Location/IsMainLocation.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\Location\\\\IsMainLocation\\:\\:createFromQueryBuilder\\(\\) has parameter \\$target with no type specified\\.$#" - count: 1 - path: src/contracts/Repository/Values/Content/Query/Criterion/Location/IsMainLocation.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\Location\\\\IsMainLocation\\:\\:createFromQueryBuilder\\(\\) has parameter \\$value with no type specified\\.$#" - count: 1 - path: src/contracts/Repository/Values/Content/Query/Criterion/Location/IsMainLocation.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\Location\\\\Priority\\:\\:createFromQueryBuilder\\(\\) has no return type specified\\.$#" - count: 1 - path: src/contracts/Repository/Values/Content/Query/Criterion/Location/Priority.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\Location\\\\Priority\\:\\:createFromQueryBuilder\\(\\) has parameter \\$operator with no type specified\\.$#" - count: 1 - path: src/contracts/Repository/Values/Content/Query/Criterion/Location/Priority.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\Location\\\\Priority\\:\\:createFromQueryBuilder\\(\\) has parameter \\$target with no type specified\\.$#" - count: 1 - path: src/contracts/Repository/Values/Content/Query/Criterion/Location/Priority.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\Location\\\\Priority\\:\\:createFromQueryBuilder\\(\\) has parameter \\$value with no type specified\\.$#" - count: 1 - path: src/contracts/Repository/Values/Content/Query/Criterion/Location/Priority.php - - - - message: "#^PHPDoc tag @param references unknown parameter\\: \\$criteria$#" - count: 1 - path: src/contracts/Repository/Values/Content/Query/Criterion/LogicalNot.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\LogicalOperator\\:\\:getSpecifications\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: src/contracts/Repository/Values/Content/Query/Criterion/LogicalOperator.php - - message: "#^Property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\MapLocationDistance\\:\\:\\$boost type has no value type specified in iterable type array\\.$#" count: 1 @@ -7210,21 +7125,6 @@ parameters: count: 1 path: src/contracts/Repository/Values/Filter/Filter.php - - - message: "#^Parameter \\#1 \\$criteria of class Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\LogicalAnd constructor expects array\\, array\\ given\\.$#" - count: 1 - path: src/contracts/Repository/Values/Filter/Filter.php - - - - message: "#^Parameter \\#1 \\$criteria of class Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\LogicalOr constructor expects array\\, array\\ given\\.$#" - count: 1 - path: src/contracts/Repository/Values/Filter/Filter.php - - - - message: "#^Property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\LogicalOperator\\:\\:\\$criteria \\(array\\\\) does not accept array\\\\.$#" - count: 2 - path: src/contracts/Repository/Values/Filter/Filter.php - - message: "#^Property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Notification\\\\CreateStruct\\:\\:\\$data type has no value type specified in iterable type array\\.$#" count: 1 @@ -7505,41 +7405,6 @@ parameters: count: 1 path: src/contracts/Test/Repository/SetupFactory/Legacy.php - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\User\\\\Identity\\:\\:addInformation\\(\\) has no return type specified\\.$#" - count: 1 - path: src/contracts/User/Identity.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\User\\\\Identity\\:\\:addInformation\\(\\) has parameter \\$information with no value type specified in iterable type array\\.$#" - count: 1 - path: src/contracts/User/Identity.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\User\\\\Identity\\:\\:getInformation\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: src/contracts/User/Identity.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\User\\\\Identity\\:\\:replaceInformation\\(\\) has no return type specified\\.$#" - count: 1 - path: src/contracts/User/Identity.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\User\\\\Identity\\:\\:replaceInformation\\(\\) has parameter \\$information with no value type specified in iterable type array\\.$#" - count: 1 - path: src/contracts/User/Identity.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\User\\\\Identity\\:\\:setInformation\\(\\) has no return type specified\\.$#" - count: 1 - path: src/contracts/User/Identity.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\User\\\\IdentityAware\\:\\:setIdentity\\(\\) has no return type specified\\.$#" - count: 1 - path: src/contracts/User/IdentityAware.php - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\Variation\\\\VariationHandler\\:\\:getVariation\\(\\) has parameter \\$parameters with no value type specified in iterable type array\\.$#" count: 1 @@ -8410,11 +8275,6 @@ parameters: count: 1 path: src/lib/Base/Utils/DeprecationWarnerInterface.php - - - message: "#^Parameter \\#1 \\$locations of class Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Events\\\\Content\\\\DeleteContentEvent constructor expects array, array\\|iterable\\ given\\.$#" - count: 1 - path: src/lib/Event/ContentService.php - - message: "#^Method Ibexa\\\\Core\\\\Event\\\\TokenService\\:\\:getToken\\(\\) should return Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Token\\\\Token but returns Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Token\\\\Token\\|string\\.$#" count: 1 @@ -9725,11 +9585,6 @@ parameters: count: 1 path: src/lib/FieldType/Selection/Type.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\StorageGateway\\:\\:setConnection\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/FieldType/StorageGateway.php - - message: "#^Parameter \\#1 \\$string of function mb_substr expects string, string\\|false given\\.$#" count: 1 @@ -10205,11 +10060,6 @@ parameters: count: 1 path: src/lib/Helper/FieldHelper.php - - - message: "#^Method Ibexa\\\\Core\\\\Helper\\\\FieldHelper\\:\\:getFieldDefinition\\(\\) should return Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\FieldDefinition but returns Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\FieldDefinition\\|null\\.$#" - count: 1 - path: src/lib/Helper/FieldHelper.php - - message: "#^Method Ibexa\\\\Core\\\\Helper\\\\FieldsGroups\\\\ArrayTranslatorFieldsGroupsList\\:\\:__construct\\(\\) has parameter \\$groups with no value type specified in iterable type array\\.$#" count: 1 @@ -11100,11 +10950,6 @@ parameters: count: 1 path: src/lib/MVC/Symfony/FieldType/RelationList/ParameterProvider.php - - - message: "#^Parameter \\#1 \\$array of function array_keys expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/MVC/Symfony/FieldType/RelationList/ParameterProvider.php - - message: "#^Cannot call method diff\\(\\) on DateTimeImmutable\\|null\\.$#" count: 1 @@ -13510,21 +13355,6 @@ parameters: count: 1 path: src/lib/Persistence/Cache/ContentTypeHandler.php - - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Cache\\\\Handler\\:\\:beginTransaction\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/Persistence/Cache/Handler.php - - - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Cache\\\\Handler\\:\\:commit\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/Persistence/Cache/Handler.php - - - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Cache\\\\Handler\\:\\:rollback\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/Persistence/Cache/Handler.php - - message: "#^Return type \\(Ibexa\\\\Core\\\\Persistence\\\\Cache\\\\URLHandler\\) of method Ibexa\\\\Core\\\\Persistence\\\\Cache\\\\Handler\\:\\:urlHandler\\(\\) should be compatible with return type \\(Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\URL\\\\Handler\\) of method Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Handler\\:\\:urlHandler\\(\\)$#" count: 1 @@ -13650,11 +13480,6 @@ parameters: count: 1 path: src/lib/Persistence/Cache/LocationHandler.php - - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Cache\\\\LocationHandler\\:\\:markSubtreeModified\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/Persistence/Cache/LocationHandler.php - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Cache\\\\LocationHandler\\:\\:setSectionForSubtree\\(\\) has no return type specified\\.$#" count: 1 @@ -15815,11 +15640,6 @@ parameters: count: 1 path: src/lib/Persistence/Legacy/Content/Location/Handler.php - - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\Location\\\\Handler\\:\\:markSubtreeModified\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/Persistence/Legacy/Content/Location/Handler.php - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\Location\\\\Handler\\:\\:move\\(\\) should return bool but return statement is missing\\.$#" count: 1 @@ -15860,16 +15680,6 @@ parameters: count: 1 path: src/lib/Persistence/Legacy/Content/Location/Handler.php - - - message: "#^Parameter \\#1 \\$nodeId of method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\Location\\\\Gateway\\:\\:getBasicNodeData\\(\\) expects int, int\\|string given\\.$#" - count: 1 - path: src/lib/Persistence/Legacy/Content/Location/Handler.php - - - - message: "#^Property Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\Location\\\\CreateStruct\\:\\:\\$pathIdentificationString \\(string\\) does not accept string\\|null\\.$#" - count: 1 - path: src/lib/Persistence/Legacy/Content/Location/Handler.php - - message: "#^Variable \\$copiedSubtreeRootLocation might not be defined\\.$#" count: 2 @@ -15895,11 +15705,6 @@ parameters: count: 1 path: src/lib/Persistence/Legacy/Content/Location/Mapper.php - - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\Location\\\\Handler\\:\\:changeMainLocation\\(\\) invoked with 4 parameters, 2 required\\.$#" - count: 1 - path: src/lib/Persistence/Legacy/Content/Location/Trash/Handler.php - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\Location\\\\Trash\\\\Handler\\:\\:loadTrashItem\\(\\) should return Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\Location\\\\Trashed but returns Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\Location\\.$#" count: 1 @@ -17660,21 +17465,6 @@ parameters: count: 1 path: src/lib/Persistence/Legacy/Filter/SortClauseVisitor.php - - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Handler\\:\\:beginTransaction\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/Persistence/Legacy/Handler.php - - - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Handler\\:\\:commit\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/Persistence/Legacy/Handler.php - - - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Handler\\:\\:rollback\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/Persistence/Legacy/Handler.php - - message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Notification\\\\Gateway\\:\\:getNotificationById\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -19010,11 +18800,6 @@ parameters: count: 1 path: src/lib/Repository/ContentService.php - - - message: "#^Parameter \\#3 \\$prioritizedLanguages of method Ibexa\\\\Core\\\\Repository\\\\Mapper\\\\ContentDomainMapper\\:\\:buildContentDomainObjectFromPersistence\\(\\) expects array\\, array\\\\|null given\\.$#" - count: 1 - path: src/lib/Repository/ContentService.php - - message: "#^Parameter \\#5 \\$fieldDefinitionId of method Ibexa\\\\Core\\\\Repository\\\\Helper\\\\RelationProcessor\\:\\:appendFieldRelations\\(\\) expects string, int given\\.$#" count: 2 @@ -19090,31 +18875,6 @@ parameters: count: 1 path: src/lib/Repository/ContentTypeService.php - - - message: "#^Cannot access property \\$fieldTypeIdentifier on Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\FieldDefinition\\|null\\.$#" - count: 1 - path: src/lib/Repository/Helper/NameSchemaService.php - - - - message: "#^Parameter \\#2 \\$fieldDefinition of method Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\FieldType\\:\\:getName\\(\\) expects Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\FieldDefinition, Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\FieldDefinition\\|null given\\.$#" - count: 1 - path: src/lib/Repository/Helper/NameSchemaService.php - - - - message: "#^Argument of an invalid type array\\\\|Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Relation supplied for foreach, only iterables are supported\\.$#" - count: 1 - path: src/lib/Repository/Helper/RelationProcessor.php - - - - message: "#^Cannot access property \\$destinationContentInfo on array\\\\|Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Relation\\.$#" - count: 1 - path: src/lib/Repository/Helper/RelationProcessor.php - - - - message: "#^Cannot access property \\$id on array\\\\|Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Relation\\.$#" - count: 1 - path: src/lib/Repository/Helper/RelationProcessor.php - - message: "#^Cannot call method error\\(\\) on Psr\\\\Log\\\\LoggerInterface\\|null\\.$#" count: 1 @@ -19515,16 +19275,6 @@ parameters: count: 1 path: src/lib/Repository/Permission/PermissionCriterionResolver.php - - - message: "#^Parameter \\#1 \\$criteria of class Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\LogicalAnd constructor expects array\\, array\\ given\\.$#" - count: 2 - path: src/lib/Repository/Permission/PermissionCriterionResolver.php - - - - message: "#^Parameter \\#1 \\$criteria of class Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\LogicalOr constructor expects array\\, array\\ given\\.$#" - count: 2 - path: src/lib/Repository/Permission/PermissionCriterionResolver.php - - message: "#^Method Ibexa\\\\Core\\\\Repository\\\\Permission\\\\PermissionResolver\\:\\:__construct\\(\\) has parameter \\$policyMap with no value type specified in iterable type array\\.$#" count: 1 @@ -19760,11 +19510,6 @@ parameters: count: 1 path: src/lib/Repository/Repository.php - - - message: "#^Parameter \\#4 \\$nameSchemaService of class Ibexa\\\\Core\\\\Repository\\\\LocationService constructor expects Ibexa\\\\Core\\\\Repository\\\\Helper\\\\NameSchemaService, Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\NameSchema\\\\NameSchemaServiceInterface given\\.$#" - count: 1 - path: src/lib/Repository/Repository.php - - message: "#^Parameter \\#5 \\$backgroundIndexer of class Ibexa\\\\Core\\\\Repository\\\\SearchService constructor expects Ibexa\\\\Core\\\\Search\\\\Common\\\\BackgroundIndexer, Ibexa\\\\Core\\\\Search\\\\Common\\\\BackgroundIndexer\\|null given\\.$#" count: 1 @@ -19780,11 +19525,6 @@ parameters: count: 1 path: src/lib/Repository/Repository.php - - - message: "#^Property Ibexa\\\\Core\\\\Repository\\\\Repository\\:\\:\\$thumbnailStrategy is never read, only written\\.$#" - count: 1 - path: src/lib/Repository/Repository.php - - message: "#^Access to protected property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\User\\\\RoleAssignment\\:\\:\\$id\\.$#" count: 1 @@ -20890,11 +20630,6 @@ parameters: count: 1 path: src/lib/Search/Common/FieldValueMapper/StringMapper.php - - - message: "#^Method Ibexa\\\\Core\\\\Search\\\\Common\\\\IncrementalIndexer\\:\\:createSearchIndex\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/Search/Common/IncrementalIndexer.php - - message: "#^Method Ibexa\\\\Core\\\\Search\\\\Common\\\\IncrementalIndexer\\:\\:purge\\(\\) has no return type specified\\.$#" count: 1 @@ -20905,11 +20640,6 @@ parameters: count: 1 path: src/lib/Search/Common/IncrementalIndexer.php - - - message: "#^Method Ibexa\\\\Core\\\\Search\\\\Common\\\\Indexer\\:\\:createSearchIndex\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/Search/Common/Indexer.php - - message: "#^Method Ibexa\\\\Core\\\\Search\\\\Common\\\\Indexer\\:\\:getContentDbFieldsStmt\\(\\) has parameter \\$fields with no value type specified in iterable type array\\.$#" count: 1 @@ -20945,11 +20675,6 @@ parameters: count: 1 path: src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler.php - - - message: "#^Access to an undefined property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\:\\:\\$criteria\\.$#" - count: 1 - path: src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/CompositeCriterion.php - - message: "#^Method Ibexa\\\\Core\\\\Search\\\\Legacy\\\\Content\\\\Common\\\\Gateway\\\\CriterionHandler\\\\CompositeCriterion\\:\\:handle\\(\\) has parameter \\$languageSettings with no value type specified in iterable type array\\.$#" count: 1 @@ -21205,11 +20930,6 @@ parameters: count: 1 path: src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/IsUserEnabled.php - - - message: "#^Access to an undefined property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\:\\:\\$matchAlwaysAvailable\\.$#" - count: 1 - path: src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/LanguageCode.php - - message: "#^Cannot call method getBitAndComparisonExpression\\(\\) on Doctrine\\\\DBAL\\\\Platforms\\\\AbstractPlatform\\|null\\.$#" count: 1 @@ -21225,31 +20945,16 @@ parameters: count: 1 path: src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/LanguageCode.php - - - message: "#^Access to an undefined property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\:\\:\\$criteria\\.$#" - count: 1 - path: src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/LogicalAnd.php - - message: "#^Method Ibexa\\\\Core\\\\Search\\\\Legacy\\\\Content\\\\Common\\\\Gateway\\\\CriterionHandler\\\\LogicalAnd\\:\\:handle\\(\\) has parameter \\$languageSettings with no value type specified in iterable type array\\.$#" count: 1 path: src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/LogicalAnd.php - - - message: "#^Access to an undefined property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\:\\:\\$criteria\\.$#" - count: 1 - path: src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/LogicalNot.php - - message: "#^Method Ibexa\\\\Core\\\\Search\\\\Legacy\\\\Content\\\\Common\\\\Gateway\\\\CriterionHandler\\\\LogicalNot\\:\\:handle\\(\\) has parameter \\$languageSettings with no value type specified in iterable type array\\.$#" count: 1 path: src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/LogicalNot.php - - - message: "#^Access to an undefined property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\:\\:\\$criteria\\.$#" - count: 1 - path: src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/LogicalOr.php - - message: "#^Method Ibexa\\\\Core\\\\Search\\\\Legacy\\\\Content\\\\Common\\\\Gateway\\\\CriterionHandler\\\\LogicalOr\\:\\:handle\\(\\) has parameter \\$languageSettings with no value type specified in iterable type array\\.$#" count: 1 @@ -26725,11 +26430,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/ContentServiceTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testLoadVersions\\(\\) should return array\\ but returns iterable\\\\.$#" - count: 1 - path: tests/integration/Core/Repository/ContentServiceTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testLoadVersionsAfterDeletingTwoDrafts\\(\\) has no return type specified\\.$#" count: 1 @@ -26990,11 +26690,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/ContentServiceTest.php - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, iterable\\ given\\.$#" - count: 2 - path: tests/integration/Core/Repository/ContentServiceTest.php - - message: "#^Parameter \\#2 \\$actualAliases of method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:assertAliasesCorrect\\(\\) expects array, iterable\\ given\\.$#" count: 4 @@ -29475,11 +29170,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/FieldType/SearchBaseIntegrationTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\SearchBaseIntegrationTest\\:\\:doModifyField\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/SearchBaseIntegrationTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\SearchBaseIntegrationTest\\:\\:findProvider\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -29505,11 +29195,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/FieldType/SearchBaseIntegrationTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\SearchBaseIntegrationTest\\:\\:modifyFieldCriterion\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/SearchBaseIntegrationTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\SearchBaseIntegrationTest\\:\\:modifyFieldSortClause\\(\\) has no return type specified\\.$#" count: 1 @@ -36480,11 +36165,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/SearchServiceTest.php - - - message: "#^Property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Search\\\\SearchHit\\:\\:\\$valueObject \\(Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ValueObject\\) does not accept array\\\\.$#" - count: 2 - path: tests/integration/Core/Repository/SearchServiceTest.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 3 @@ -47115,16 +46795,6 @@ parameters: count: 1 path: tests/lib/Persistence/Cache/PersistenceLoggerTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Persistence\\\\Cache\\\\PersistenceLoggerTest\\:\\:testGetCount\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Persistence/Cache/PersistenceLoggerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Persistence\\\\Cache\\\\PersistenceLoggerTest\\:\\:testGetCountValues\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Persistence/Cache/PersistenceLoggerTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Persistence\\\\Cache\\\\PersistenceLoggerTest\\:\\:testGetName\\(\\) has no return type specified\\.$#" count: 1 @@ -47630,11 +47300,6 @@ parameters: count: 1 path: tests/lib/Persistence/Legacy/Content/ContentHandlerTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\ContentHandlerTest\\:\\:testLoadRelations\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Persistence/Legacy/Content/ContentHandlerTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\ContentHandlerTest\\:\\:testLoadReverseRelations\\(\\) has no return type specified\\.$#" count: 1 @@ -49305,11 +48970,6 @@ parameters: count: 1 path: tests/lib/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabaseTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\Location\\\\Gateway\\\\DoctrineDatabaseTest\\:\\:testUpdateSubtreeModificationTime\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabaseTest.php - - message: "#^Parameter \\#2 \\$y of method Doctrine\\\\DBAL\\\\Query\\\\Expression\\\\ExpressionBuilder\\:\\:in\\(\\) expects array\\\\|string, array\\ given\\.$#" count: 11 @@ -49517,7 +49177,7 @@ parameters: - message: "#^Call to an undefined method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\Location\\\\Handler\\:\\:expects\\(\\)\\.$#" - count: 4 + count: 1 path: tests/lib/Persistence/Legacy/Content/Location/TrashHandlerTest.php - @@ -49577,7 +49237,7 @@ parameters: - message: "#^Call to an undefined method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\Location\\\\Gateway\\:\\:expects\\(\\)\\.$#" - count: 22 + count: 20 path: tests/lib/Persistence/Legacy/Content/LocationHandlerTest.php - @@ -49645,11 +49305,6 @@ parameters: count: 1 path: tests/lib/Persistence/Legacy/Content/LocationHandlerTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\LocationHandlerTest\\:\\:testMarkSubtreeModified\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Persistence/Legacy/Content/LocationHandlerTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\LocationHandlerTest\\:\\:testMoveSubtree\\(\\) has no return type specified\\.$#" count: 1 @@ -52965,11 +52620,6 @@ parameters: count: 1 path: tests/lib/Persistence/Legacy/User/UserHandlerTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Persistence\\\\Legacy\\\\User\\\\UserHandlerTest\\:\\:testLoadPoliciesForUser\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Persistence/Legacy/User/UserHandlerTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Persistence\\\\Legacy\\\\User\\\\UserHandlerTest\\:\\:testLoadRole\\(\\) has no return type specified\\.$#" count: 1 @@ -53575,11 +53225,6 @@ parameters: count: 1 path: tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php - - - message: "#^Parameter \\#1 \\$contentIds of method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\ContentService\\:\\:loadContentInfoList\\(\\) expects array\\, array\\ given\\.$#" - count: 1 - path: tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php - - message: "#^Parameter \\#2 \\$locationCreateStructs of method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\ContentService\\:\\:createContent\\(\\) expects array\\, array\\ given\\.$#" count: 1 @@ -58465,16 +58110,6 @@ parameters: count: 1 path: tests/lib/Repository/Values/Filter/FilterTest.php - - - message: "#^Parameter \\#1 \\$criterion of method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Filter\\\\Filter\\:\\:orWithCriterion\\(\\) expects Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Filter\\\\FilteringCriterion, Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion given\\.$#" - count: 1 - path: tests/lib/Repository/Values/Filter/FilterTest.php - - - - message: "#^Parameter \\#1 \\$criterion of method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Filter\\\\Filter\\:\\:withCriterion\\(\\) expects Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Filter\\\\FilteringCriterion, Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion given\\.$#" - count: 1 - path: tests/lib/Repository/Values/Filter/FilterTest.php - - message: "#^Parameter \\#1 \\$value of class Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\Criterion\\\\RemoteId constructor expects array\\\\|string, int given\\.$#" count: 1 diff --git a/src/contracts/Repository/Values/Filter/Filter.php b/src/contracts/Repository/Values/Filter/Filter.php index ce6203c6fb..a0b660400d 100644 --- a/src/contracts/Repository/Values/Filter/Filter.php +++ b/src/contracts/Repository/Values/Filter/Filter.php @@ -111,10 +111,6 @@ public function andWithCriterion(FilteringCriterion $criterion): self } elseif ($this->criterion instanceof Criterion\LogicalAnd) { $this->criterion->criteria[] = $criterion; } else { - // $this->criterion is array of \Ibexa\Contracts\Core\Repository\Values\Filter\FilteringCriterion - // but \Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\LogicalOperator - // accepts only \Ibexa\Contracts\Core\Repository\Values\Content\Query\CriterionInterface - /** @phpstan-ignore argument.type */ $this->criterion = new Criterion\LogicalAnd([$this->criterion, $criterion]); } @@ -132,7 +128,6 @@ public function orWithCriterion(FilteringCriterion $criterion): self } elseif ($this->criterion instanceof Criterion\LogicalOr) { $this->criterion->criteria[] = $criterion; } else { - /** @phpstan-ignore argument.type */ $this->criterion = new Criterion\LogicalOr([$this->criterion, $criterion]); }