Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapes in readme images can't be seen with GH's dark mode #154

Open
jjant opened this issue Mar 13, 2022 · 2 comments
Open

Shapes in readme images can't be seen with GH's dark mode #154

jjant opened this issue Mar 13, 2022 · 2 comments

Comments

@jjant
Copy link

jjant commented Mar 13, 2022

Basically the title, shapes are black with a transparent background, which makes them invisible in dark mode:

image

@ianmackenzie
Copy link
Owner

I wonder what the best solution is here...it looks like it's now possible to specify theme-specific images but that will almost certainly mess up how the README is displayed on package.elm-lang.org (both images will get displayed). I guess I could do something like use theme-specific images on master, and for every published version of elm-geometry create a release branch where the README only has the light mode images so it renders properly on the package site...a bit annoying but that's the only approach I can think of that makes things look good in all three cases (GitHub light mode, GitHub dark mode, Elm package site). Thoughts?

@jjant
Copy link
Author

jjant commented Mar 28, 2022

@ianmackenzie I think the common solution for these kinds of things is to use outlines and fills for everything (as they do for subtitles, for ex).

If you do that, and/or use exotic colours (magenta, bright greens), you should cover most cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants