Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More optimal 0D positivity constraint? #25

Open
ianan opened this issue Apr 26, 2022 · 0 comments
Open

More optimal 0D positivity constraint? #25

ianan opened this issue Apr 26, 2022 · 0 comments

Comments

@ianan
Copy link
Owner

ianan commented Apr 26, 2022

Current python code is based on idl map approach where it finds (in default mode considering the positivity constrain) the regularization parameter λ from a range of values of λ, the one that satisfies

[1]. ||Kξλ -g||2 - ρ||δg||2 = min

But if ξλ < 0 repeats the above condition, increasing ρ, again looking for the λ that satisfies it, doing this iteratively until ξλ > 0 or max_iter is reached. This is the 'faster' approach used in the maps as only have to compute one ξλ and check its positivity once found the λ that satisfies [1], since [1] computable directly from GSVD output (i.e. don't need to compute ξλ to get [1].).

Would it be more optimal (avoiding while loop and ρ tweaking) to instead compute ξλ for a larger sample of λ values and then for the subset that satisfy ξλ > 0 only then do the [1]. condition. Likely would find higher minimum, which is equivalent to increasingly ρ in current approach. This newer version should find the best solution but might be slower to compute (i.e. bad for maps) since having to do lots of ξλ and then [1].

Shouldn't be as 'slow; as original approach in idl_org pos where [1]. and ξλ where both calculate for a large sample of λ and then λ satisfying the joint criteria was found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant