Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend checks for more Python-s and fix annotations for Python 3.8 #78

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

iamleot
Copy link
Owner

@iamleot iamleot commented Dec 3, 2023

Extend checks for more Python-s

Add a matrix in order to check at least:

  • oldest Python version
  • default Python version on pkgsrc-current
  • newest Python version

Set fail-fast to false (by default it is true) in order to run all matrix jobs to see all Python versions that fail instead of pointing out only the first (and non-deterministic) one that fails.


Switch to use typing.Dict

Python 3.8 annotations needs Dict from typing.Dict (i.e. direct `dict is not usable).

Switch to use it in order to be usable from all Python versions.


Related/closes #49 and #71.

@iamleot iamleot added the enhancement New feature or request label Dec 3, 2023
@iamleot iamleot self-assigned this Dec 3, 2023
@iamleot iamleot force-pushed the python-matrix-versions-and-support-3.8 branch 2 times, most recently from ab504fd to b892829 Compare December 3, 2023 12:48
Add a matrix in order to check at least:

- oldest Python version
- default Python version on pkgsrc-current
- newest Python version

Set `fail-fast` to `false` (by default it is `true`) in order to run
all matrix jobs to see all Python versions that fail instead of
pointing out only the first (and non-deterministic) one that fails.

Related to #49 and #71.
@iamleot iamleot force-pushed the python-matrix-versions-and-support-3.8 branch from b892829 to 4bc082f Compare December 3, 2023 12:49
Python 3.8 annotations needs Dict from typing.Dict (i.e. direct `dict`
is not usable).

Switch to use it in order to be usable from all Python versions.

Related/closes #49 and #71.
@iamleot iamleot marked this pull request as ready for review December 3, 2023 13:01
@iamleot iamleot merged commit dc531dc into master Dec 3, 2023
5 checks passed
@iamleot iamleot deleted the python-matrix-versions-and-support-3.8 branch December 3, 2023 13:01
@iamleot iamleot mentioned this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with 3.8
1 participant