-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactoring: Modify the project source code to enable new analysis easily integrated #104
Comments
The new structure of the custom folder:
Developers should add each component to the customization.module.ts after adding them. |
For the analysis components inside the analyses folder collect the helper methods that are same for the each query component to one file called query-helper.ts |
Developer guide for the developers; |
Adding query component interface and modifying all analysis components as they implement that interface. import { TableViewInput, TableFiltering, TableData } from '../../shared/table-view/table-view-types';
import { Subject } from 'rxjs';
import { GraphResponse } from 'src/app/visuall/db-service/data-types';
export interface QueryComponent<T> {
tableInput: TableViewInput;
tableFilled: Subject<boolean>;
tableResponse: T;
graphResponse: GraphResponse;
clearTableFilter: Subject<boolean>;
ngOnInit(): void;
prepareQuery(): void;
loadTable(skip: number, filter?: TableFiltering): void;
loadGraph(skip: number, filter?: TableFiltering): void;
filterGraphResponse(x: GraphResponse): GraphResponse;
fillTable(data: T[], totalDataCount: number | null): void;
getDataForQueryResult(e: any): void;
filterTable(filter: TableFiltering): void;
filterTableResponse(x: T[], filter: TableFiltering): T[];
} |
The structure of the custom folder changed as;
|
For easier integration of new analyses into our project, we should restructure the repository to allow other developers to easily integrate their work.
The text was updated successfully, but these errors were encountered: