Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wing launch mode failsafe fixes #10486

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

breadoven
Copy link
Collaborator

Closes #10483.

@breadoven breadoven added this to the 8.0 milestone Nov 28, 2024
@Jetrell
Copy link

Jetrell commented Dec 5, 2024

I gave it a test by taking off in Auto Launch and letting it climb for a while, then switched to FS mode.
It proceeded to enter RTH and once it got close to the Safehome it started the LAND procedure, which I have enabled.. I tested it twice and it performed the same.. So the fix appears to work.

RTH state and decides it's failed causing failsafe to default to Emergency Landing instead

Can I assume you had to do a scheduling work around to get this to initialize ? I noticed when it entered FS in AutoLaunch ALL the OSD screen characters will systematically flash. Like an OSD refresh was missed at that moment (Analog video).
This is no big issue. I just thought it worth mentioning.
EDIT: Having another look. It may just be that SDIO logging issue with the F765. It affects the OSD too, when more demanding tasks are being performed. Even with a low 3% rate.

Guess not many people have Failsafe's during launch because these bugs have been there for a long time.

I've never had a FS happen at launch.. But after reviewing old mates video.. He was at 325m and AutoLaunch was still going.
At that altitude the TX/RX antenna's would have been operating in their null's.

And as a side note to this being an old bug.. I remember an issue report being opened by a user back in INAV 2.0.. I had a look, but couldn't find it.
It was about a guy who auto launched his plane. And at the moment he threw it, the throw inertia disconnected his RX plug, and the FC entered FS.
From what I vaguely remember. At the time, Konstantin wanted to leave it as DROP... In cases like this, when entering an nav_rth_altitude mode that has no climb out, could cause the plane to turn into an object like a tree, if a FS condition was entered straight after the throw.
Back at the time there was debate about this and nothing was obviously done... In hindsight I think a method to deal with this would be to have nav_rth_altitude overridden to EXTRA, if an Auto Launch FS occurred at less than 40m above the arming altitude.

But in any case, I think your fix was more needed than not.

@b14ckyy
Copy link
Collaborator

b14ckyy commented Dec 5, 2024

Finally managed to run some HITL tests last night as well. Can confirm that no issues appeared when FS during Autolaunch, even with long climbs and distances. That was on a F405 though.

@MrD-RC
Copy link
Collaborator

MrD-RC commented Dec 5, 2024

So the lowest spec supported MCU 😉

@MrD-RC
Copy link
Collaborator

MrD-RC commented Dec 5, 2024

Both tests look positive. So I'll merge it for RC2.

@MrD-RC MrD-RC merged commit 9e8bd55 into iNavFlight:master Dec 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disarmed by Failsafe when the aircraft should entered have RTH
4 participants