Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement Suggestion for Discord #91

Open
SpawW opened this issue Jul 30, 2024 · 1 comment
Open

Improvement Suggestion for Discord #91

SpawW opened this issue Jul 30, 2024 · 1 comment

Comments

@SpawW
Copy link

SpawW commented Jul 30, 2024

In last months the updates in terraform module improve telegram and microsoft teams support and now, for both tools, we don't need more to use an separated alert_connector to create the alert_action.

I like to suggest to add an "discord_webhook" argument like the recent "microsoft_teams_webhook".

So we can have an block configuration like this...

resource "ilert_alert_action" "dev_discord" {
...
  discord_webhook {
    url = "https://discord.com/api/webhooks/123"
  }
  connector {
    type = "discord"
  }
 ...
}

Instead of this:

resource "ilert_alert_action" "dev_discord" {

...
  connector {
    id   = ilert_connector.dev_discord.id
    type = ilert_connector.dev_discord.type
  }
 ...
 }
 
 resource "ilert_connector" "dev_discord" {
  name = "dev/discord"
  type = "discord"
  discord {
    url = "https://discord.com/api/webhooks/123"
  }
}

With this the terraform files will be more easy to build and maintain and you can do the deduplication of connectors to avoid duplicate configurations inside ilert platform.

@krystianity
Copy link
Member

Thanks for the suggestion @SpawW it definitely makes sense to go for this when we further introduce a real discord bot. I dont know if we will have a standlone webhook version before introducing the Discord bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants