You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The comment here directly contradicts to what code is doing?
Array of hits provided to the fitter is sorted in rho in the processor (although not required anywhere by the fitter).
Looping over these hits will give us sorting by rho, but not by fitting order as comment states.
In the contrary, if one wants to get hits in the fitting order, one would need to loop over hits_in_fit which is in the code, but completely stays unused.
Would be nice to fix the comment, to avoid further confusion, or change the hit order in tracks, sorted by rho is not how we want them.
The text was updated successfully, but these errors were encountered:
The comment here directly contradicts to what code is doing?
Array of hits provided to the fitter is sorted in
rho
in the processor (although not required anywhere by the fitter).Looping over these hits will give us sorting by rho, but not by fitting order as comment states.
In the contrary, if one wants to get hits in the fitting order, one would need to loop over
hits_in_fit
which is in the code, but completely stays unused.Would be nice to fix the comment, to avoid further confusion, or change the hit order in tracks, sorted by rho is not how we want them.
The text was updated successfully, but these errors were encountered: