Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit order in the refitted track #18

Open
dudarboh opened this issue Aug 22, 2021 · 0 comments
Open

Hit order in the refitted track #18

dudarboh opened this issue Aug 22, 2021 · 0 comments

Comments

@dudarboh
Copy link
Member

The comment here directly contradicts to what code is doing?

Array of hits provided to the fitter is sorted in rho in the processor (although not required anywhere by the fitter).
Looping over these hits will give us sorting by rho, but not by fitting order as comment states.

In the contrary, if one wants to get hits in the fitting order, one would need to loop over hits_in_fit which is in the code, but completely stays unused.

Would be nice to fix the comment, to avoid further confusion, or change the hit order in tracks, sorted by rho is not how we want them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant