New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of vectors in streaming handlers #144

Open

tmadlener opened this issue Oct 29, 2021 · 0 comments

Labels

enhancement help wanted

Contributor

tmadlener commented Oct 29, 2021 •

edited

Loading

In some places vector elements are copied element by element into the sio stream, e.g.

LCIO/src/cpp/src/SIO/SIOLCParameters.cc

Lines 62 to 65 in 1287e94

    
           SIO_DATA( device , &nInt , 1 ) ; 
        
             for(int j=0; j< nInt ; j++ ) { 
        
               SIO_SDATA( device, intVec[j]  ) ; 
        
              }

sio should be able to handle vectors as a whole, without having to read each element separately. We do this in podio: https://github.com/AIDASoft/podio/blob/master/src/SIOBlock.cc#L47-L67

	SIO_SDATA(device, intVec);

Originally posted by @tmadlener in #143 (comment)

tmadlener added enhancement help wanted labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment